London | 26-SDC-Mar |Shaghayeghfar | Sprint 3 | Implement-shell-tools#456
Open
shaghayeghfar wants to merge 1 commit into
Open
London | 26-SDC-Mar |Shaghayeghfar | Sprint 3 | Implement-shell-tools#456shaghayeghfar wants to merge 1 commit into
shaghayeghfar wants to merge 1 commit into
Conversation
shaghayeghfar
added
Needs Review
SlideGauge
reviewed
May 30, 2026
SlideGauge
left a comment
SlideGauge
left a comment
There was a problem hiding this comment.
Good job, there a couple of notes from my side, fix them please
|
|
||
| console.log(output.trim()); | ||
| } catch (err) { | ||
| console.error(`wc: cannot open ${file}`); |
There was a problem hiding this comment.
Looks like the whole cat.js file has wc tool inside, not cat
| continue; | ||
| } | ||
|
|
||
| console.log(file); |
There was a problem hiding this comment.
real ls default output puts all files on one line separated by spaces; one-per-line requires the -1 flag. The -1 flag is not implemented here.
| const folder = args.filter((arg) => !arg.startsWith("-"))[0] || "."; | ||
|
|
||
| // read directory | ||
| const files = fs.readdirSync(folder); |
There was a problem hiding this comment.
What happens if no folder is found?
| } catch (err) { | ||
| console.error(`wc: cannot open ${file}`); | ||
| } | ||
| } |
There was a problem hiding this comment.
Missing totals row for multiple files. When more than one file is given, real wc prints a total line at the end.
|
|
||
| // if no flag → show all | ||
| if (!showLines && !showWords && !showBytes) { | ||
| output = `${lines} ${words} ${bytes} ${file}`; |
There was a problem hiding this comment.
Numbers are not right-aligned. Real wc uses fixed-width columns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I Implement shell tools in JavaScript with NodeJS.