Skip to content

fix(Flyout): Update IconButton aria-label to use closeLabel prop - #3401

Merged
aresnik11 merged 3 commits into
mainfrom
ajr-fix-flyout-aria-label
Jul 30, 2026
Merged

fix(Flyout): Update IconButton aria-label to use closeLabel prop#3401
aresnik11 merged 3 commits into
mainfrom
ajr-fix-flyout-aria-label

Conversation

@aresnik11

@aresnik11 aresnik11 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Overview

Currently the Flyout close IconButton aria-label is hard-coded to "Close". This updates it to use the closeLabel prop that defaults to "Close" but is overridable.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1721
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Go to Flyout story
  2. Open VO and confirm the x-button is read as "close flyout, button"

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud

nx-cloud Bot commented Jul 29, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 87f0eef


☁️ Nx Cloud last updated this comment at 2026-07-29 20:26:19 UTC

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@f96f976). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3401   +/-   ##
=======================================
  Coverage        ?   90.10%           
=======================================
  Files           ?      270           
  Lines           ?     5700           
  Branches        ?     1925           
=======================================
  Hits            ?     5136           
  Misses          ?      555           
  Partials        ?        9           
Flag Coverage Δ
pull-request 90.10% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecademydev

Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 72.3.1-alpha.a44e4f.0 npm diff
@codecademy/gamut-icons 9.57.11-alpha.a44e4f.0 npm diff
@codecademy/gamut-illustrations 0.58.16-alpha.a44e4f.0 npm diff
@codecademy/gamut-kit 3.0.11-alpha.a44e4f.0 npm diff
@codecademy/gamut-patterns 0.10.35-alpha.a44e4f.0 npm diff
@codecademy/gamut-styles 20.0.3-alpha.a44e4f.0 npm diff
@codecademy/gamut-tests 6.0.6-alpha.a44e4f.0 npm diff
@codecademy/variance 0.26.2-alpha.a44e4f.0 npm diff
eslint-plugin-gamut 2.4.4-alpha.a44e4f.0 npm diff

@aresnik11
aresnik11 marked this pull request as ready for review July 29, 2026 20:29
@aresnik11
aresnik11 requested a review from a team as a code owner July 29, 2026 20:29
@github-actions

Copy link
Copy Markdown
Contributor

@aresnik11
aresnik11 merged commit cd56655 into main Jul 30, 2026
18 of 19 checks passed
@aresnik11
aresnik11 deleted the ajr-fix-flyout-aria-label branch July 30, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants