Fix keyboard shortcuts under non-Latin keyboard layouts#1027
Fix keyboard shortcuts under non-Latin keyboard layouts#1027b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0 wants to merge 4 commits into
Conversation
FXMisc/RichTextFX#1255 - IIRC this was fixed upstream for RichTextFX text area components (Save, find, etc in the decompiled code editor) When we reported the issue, those combinations did work with alternative key layouts (core JavaFX controls)/ These combinations not working anymore in the places you've made fixes to seems to imply a regression upstream in core FX. Could you try and re-create the problem with these keys not working on a basic hello-world scale JavaFX screen?
I have no idea what this means. |
Tested with a minimal JavaFX repro (TextField, TextArea, RichTextFX CodeArea) on a non-Latin keyboard layout — Ctrl+C/V works in all three. So this doesn't look like a core JavaFX regression on my side; the issue appears Recaf-specific. I'll narrow the PR to Recaf keybinding matching and remove the scene-level event normalization. |
1.mp4 |
That line meant a scene-level filter that re-dispatched key events when Ctrl+letter produced a layout-specific KeyCode instead of the expected one. I've removed it. Hello-world testing showed copy/paste already works in core JavaFX and RichTextFX, so the PR now only covers Recaf keybinding matching. Also added the missing Russian translations in the same PR. I know it would've been cleaner as a separate PR, but I already had this one open, so I just whipped up a quick Python script to sync the keys with en_US and filled in the translations. |
What's new
What's fixed