Skip to content

N°9678 - Datamodel not added after extension management setup#936

Merged
eespie merged 6 commits into
developfrom
issue/9678-fixchoosenextensions
Jun 17, 2026
Merged

N°9678 - Datamodel not added after extension management setup#936
eespie merged 6 commits into
developfrom
issue/9678-fixchoosenextensions

Conversation

@odain-cbd

Copy link
Copy Markdown
Contributor

No description provided.

@odain-cbd odain-cbd requested review from Lenaick and eespie June 11, 2026 11:21
@odain-cbd odain-cbd self-assigned this Jun 11, 2026
@odain-cbd odain-cbd added the internal Work made by Combodo label Jun 11, 2026
@greptile-apps

greptile-apps Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR centralizes extension map discovery and adjusts setup compilation paths. The main changes are:

  • Replaces direct iTopExtensionsMap construction with a shared factory.
  • Tracks scanned module root directories on the extension map.
  • Updates setup and data-audit compilation to use selected extensions and modules differently.
  • Adds feature-removal coverage for newly added extensions during dry removal.
  • Updates setup unit tests and fixtures around extension maps and compilation.

Confidence Score: 3/5

This should be fixed before merging.

  • The data-audit compile path can ignore the wizard-selected source tree.
  • Upgrade checks can run against the wrong datamodel roots.
  • The previously reported Hub download issue still affects an extension install path.

setup/runtimeenv.class.inc.php

Reviews (4): Last reviewed commit: "N°9678 - Refactor data model compilation..." | Re-trigger Greptile

Comment thread setup/runtimeenv.class.inc.php Outdated
@odain-cbd odain-cbd closed this Jun 11, 2026
Comment thread setup/extensionsmap.class.inc.php Outdated
@odain-cbd odain-cbd reopened this Jun 11, 2026
@odain-cbd odain-cbd closed this Jun 15, 2026
@odain-cbd odain-cbd reopened this Jun 15, 2026
Comment thread datamodels/2.x/itop-hub-connector/land.php
@eespie eespie closed this Jun 16, 2026
@eespie eespie reopened this Jun 16, 2026
@eespie eespie closed this Jun 16, 2026
@eespie eespie reopened this Jun 16, 2026
Comment thread setup/runtimeenv.class.inc.php
…move unnecessary error logging in WizStepModulesChoice
@eespie eespie merged commit 207ac37 into develop Jun 17, 2026
@eespie eespie deleted the issue/9678-fixchoosenextensions branch June 17, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants