Migrate from ESLint to oxlint by nstepien · Pull Request #4119 · Comcast/react-data-grid

nstepien · 2026-07-27T19:40:21Z

Replaces ESLint with oxlint for JS/TS linting. ESLint stays only for markdown, since @eslint/markdown is built on ESLint's language plugin API, which oxlint does not support.

.oxlintrc.json was generated with @oxlint/migrate --type-aware --with-nursery and carries over 545 rules at their original warn severity. @eslint-react and sonarjs load as jsPlugins; typescript, react and vitest use oxlint's native implementations, so typescript-eslint, eslint-plugin-react-hooks and @vitest/eslint-plugin are dropped.

Scripts

before	after
`node --run eslint`	`node --run lint` (oxlint) + `node --run lint:md` (markdown)
`node --run eslint:fix`	`node --run lint:fix` / `node --run lint:md:fix`

--report-unused-disable-directives is passed to oxlint to match ESLint 9's default behaviour. CI, publish.yml, AGENTS.md and .vscode/settings.json are updated to match.

Rules that could not be migrated

The 13 React Compiler rules (react-hooks/purity, preserve-manual-memoization, set-state-in-effect, …). oxlint only ships these as a single experimental bundled react/react-compiler rule, and will split them once they stabilise. This is the most substantive loss — happy to keep a narrow ESLint config for them alongside markdown if we'd rather not go without.
@eslint-react/no-implicit-key, no-leaked-conditional-rendering, no-unused-props. oxlint's JS plugin API cannot supply @typescript-eslint parser services, so these throw on every file rather than running.
@typescript-eslint/naming-convention, prefer-destructuring, no-unused-private-class-members, require-atomic-updates, one-var.

Everything else is covered, including all 40 type-aware @typescript-eslint rules via oxlint-tsgolint.

Suppressions added

Three, each a behavioural difference rather than a real defect:

sonarjs/no-redundant-optional in src/types.ts — cannot see exactOptionalPropertyTypes without type information, so it flags the intentional ?: boolean | undefined.
vitest/no-conditional-expect in scrollToCell.test.tsx — oxlint flags a helper function that is not a test block.
The existing directive in src/globals.d.ts moved down one line, because oxlint reports the index signature where ESLint reported the interface.

The other 15 eslint-disable comments work unchanged — oxlint accepts the @typescript-eslint/ prefix, and the unused-directive check confirms all of them are still live.

Incidental

@eslint-react/component-hook-factories was removed: it does not exist in that plugin and ESLint silently ignored it because it was off. It was most likely meant to be react-hooks/component-hook-factories.

.agents is ignored by both linters, mirroring the existing .claude entry.

Known issue: `--type-aware` on Windows

oxlint 1.76.0 only looks for node_modules/.bin/tsgolint.exe, but npm writes .cmd/.ps1 shims there, so node --run lint fails locally on Windows with "Failed to find tsgolint executable". TSGOLINT_PATH does not help and 1.76.0 is the latest release. CI on ubuntu-latest is unaffected, and oxlint exits 1 rather than silently skipping the rules. Local workaround:

Copy-Item node_modules\@oxlint-tsgolint\win32-x64\tsgolint.exe node_modules\.bin\tsgolint.exe -Force

The oxc VS Code extension has an oxc.path.tsgolint setting that avoids this for editor diagnostics.

Verification

node --run lint, node --run lint:md, node --run typecheck, node --run format:check all pass, and the full suite is green (353 passed, 2 skipped across 65 files).

🤖 Generated with Claude Code

Replace ESLint with oxlint for JS/TS linting, keeping ESLint only for markdown (`@eslint/markdown` uses ESLint's language plugin API, which oxlint does not support). `.oxlintrc.json` was generated by `@oxlint/migrate --type-aware --with-nursery` and carries over 545 rules at their original `warn` severity. `@eslint-react` and `sonarjs` are loaded as `jsPlugins`; `typescript`, `react` and `vitest` use oxlint's native implementations, so `typescript-eslint`, `eslint-plugin-react-hooks` and `@vitest/eslint-plugin` are no longer needed. Rules that could not be migrated: - the 13 React Compiler rules (`react-hooks/purity`, `preserve-manual-memoization`, …) — oxlint only ships these as an experimental bundled `react/react-compiler` rule - `@eslint-react/no-implicit-key`, `no-leaked-conditional-rendering` and `no-unused-props` — oxlint's JS plugin API cannot supply parser services, so these throw on every file - `@typescript-eslint/naming-convention`, `prefer-destructuring`, `no-unused-private-class-members`, `require-atomic-updates`, `one-var` Three suppressions were added for behavioural differences rather than real defects: `sonarjs/no-redundant-optional` cannot see `exactOptionalPropertyTypes` without type information, and `vitest/no-conditional-expect` flags a helper that is not a test block. The existing directive in `globals.d.ts` moved down a line because oxlint reports the index signature where ESLint reported the interface. `@eslint-react/component-hook-factories` was dropped: it does not exist in that plugin and was silently ignored by ESLint because it was `off`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

amanmahajan7 · 2026-07-28T15:29:50Z

+    "correctness": "off"
+  },
+  "options": {
+    "typeAware": true


Worth enabling typeCheck? Would that cover all the files checked by the typecheck command?

Done.
I've kept the typecheck command since it's very useful with --watch.
oxlint does not support --watch

amanmahajan7 · 2026-07-28T15:30:36Z

+        "@eslint-react/naming-convention-context-name": "warn",
+        "@eslint-react/naming-convention-id-name": "warn",
+        "@eslint-react/naming-convention-ref-name": "warn",
+        "sonarjs/anchor-precedence": "warn",


Wonder if we should look into unicorn rules. Seems like it can replaces some of the the sonarjs rules

I wouldn't mind removing the sonarjs rules

I've removed the sonarjs rules. We can look into enabling unicorn rules in a separate PR

amanmahajan7 · 2026-08-21T16:52:27Z

This will be a great PR to finish and merge now that oxlint supports react compiler rules. I think we can get rid of eslint completely. For markdown, we can wait for oxlint to support it oxc-project/oxc#18407

nstepien · 2026-08-21T21:28:34Z

+  // ESLint is only used for markdown; JS/TS is linted by the oxc extension
+  "eslint.validate": ["markdown"],
  "eslint.problems.shortenToSingleLine": true,
+  "oxc.path.tsgolint": "node_modules/.bin/tsgolint.cmd",


need this otherwise type-aware rules don't work, but that path won't work outside windows... should we only set this path in our own individual settings?

nstepien · 2026-08-21T21:33:51Z

@@ -0,0 +1 @@
+@AGENTS.md


https://code.claude.com/docs/en/memory#agents-md

nstepien · 2026-08-22T01:54:25Z

Ready for review.
There's still some work to be done, like enabling the react compiler rules, but we can leave that for a separate PR.

I think we can get rid of eslint completely. For markdown, we can wait for oxlint to support it oxc-project/oxc#18407

I've kept eslint to lint the markdown files. It's fast and shouldn't be much of an issue.

nstepien and others added 2 commits July 27, 2026 20:39

remove references to .agents

d4e722d

amanmahajan7 reviewed Jul 28, 2026

View reviewed changes

nstepien self-assigned this Jul 28, 2026

nstepien added 9 commits August 21, 2026 18:46

Merge branch 'main' into migrate-to-oxlint

d9473d1

yaml tweaks

0f8be58

fix double lint

c1ccf4f

settings tweaks

b7aee53

tweak eslint usage

b9b6d4f

disallow br

a75da2d

add CLAUDE.md symlink

0530500

re-enable typeAware

f8b60ad

enable typeCheck

a912743

nstepien commented Aug 21, 2026

View reviewed changes

symlink -> file

bb65dd0

nstepien commented Aug 21, 2026

View reviewed changes

Comment thread CLAUDE.md

@@ -0,0 +1 @@

@AGENTS.md

nstepien Aug 21, 2026

Copy link
Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://code.claude.com/docs/en/memory#agents-md

nstepien added 9 commits August 21, 2026 22:44

nude sonarjs

9e4aacf

tweak settings

cacbfef

tweak rules

62c881d

fix CLAUDE.md

ce897f5

sort rules

eb84db9

review

6420b45

use default categories settings

46619a1

npm dedupe

a4f0940

npm audit fix

42dca4e

nstepien marked this pull request as ready for review August 22, 2026 01:50

nstepien requested a review from amanmahajan7 August 22, 2026 01:50

nstepien enabled auto-merge (squash) August 22, 2026 01:55

Navigation Menu

Uh oh!

Migrate from ESLint to oxlint - #4119

Migrate from ESLint to oxlint#4119
nstepien wants to merge 21 commits into
mainfrom
migrate-to-oxlint

nstepien commented Jul 27, 2026

Uh oh!

amanmahajan7 Jul 28, 2026

Uh oh!

nstepien Aug 22, 2026

Uh oh!

amanmahajan7 Jul 28, 2026

Uh oh!

nstepien Jul 28, 2026

Uh oh!

nstepien Aug 22, 2026

Uh oh!

amanmahajan7 commented Aug 21, 2026

Uh oh!

nstepien Aug 21, 2026

Uh oh!

nstepien Aug 21, 2026

Uh oh!

nstepien commented Aug 22, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

nstepien commented Jul 27, 2026

Scripts

Rules that could not be migrated

Suppressions added

Incidental

Known issue: --type-aware on Windows

Verification

Uh oh!

amanmahajan7 Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

nstepien Aug 22, 2026

Choose a reason for hiding this comment

Uh oh!

amanmahajan7 Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

nstepien Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

nstepien Aug 22, 2026

Choose a reason for hiding this comment

Uh oh!

amanmahajan7 commented Aug 21, 2026

Uh oh!

nstepien Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

nstepien Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

nstepien commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Known issue: `--type-aware` on Windows

nstepien commented Aug 22, 2026 •

edited

Loading