fix: add timeout to PyPI update check to prevent hanging offline#378
Merged
fix: add timeout to PyPI update check to prevent hanging offline#378
Conversation
09368fc to
1e676ee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #378 +/- ##
==========================================
+ Coverage 62.87% 62.99% +0.11%
==========================================
Files 33 33
Lines 3688 3691 +3
==========================================
+ Hits 2319 2325 +6
+ Misses 1369 1366 -3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requests.get() in check_for_newer_pypi_version() had no timeout, causing comfy launch, comfy env, and comfy install to hang indefinitely in offline or containerized environments.
Added a 3-second timeout and a logging.warning() on failure so it fails gracefully instead of blocking forever. Added tests covering newer version detection, same version, timeout, connection error, and HTTP error scenarios.
Closes #175. Supersedes #183 (that PR also fixed config_manager bool handling and tracking, both of which have been addressed separately since then).