Bump Microsoft.AspNetCore.OpenApi globally and remove local override - #1515
Bump Microsoft.AspNetCore.OpenApi globally and remove local override#1515aaronpowell with Copilot wants to merge 3 commits into
Microsoft.AspNetCore.OpenApi globally and remove local override#1515Conversation
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Microsoft.AspNetCore.OpenApi globally and remove local override
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1515Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1515" |
There was a problem hiding this comment.
Pull request overview
This PR centralizes the Microsoft.AspNetCore.OpenApi package version in the repo’s central package management to eliminate drift caused by a per-project override in an example project.
Changes:
- Updated central package version for
Microsoft.AspNetCore.OpenApiinDirectory.Packages.propsfrom8.0.20to10.0.10. - Removed the
VersionOverrideforMicrosoft.AspNetCore.OpenApiin the SurrealDb ApiService example so it inherits the centrally managed version.
Show a summary per file
| File | Description |
|---|---|
| Directory.Packages.props | Bumps Microsoft.AspNetCore.OpenApi centrally so all projects resolve the same version. |
| examples/surrealdb/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService.csproj | Removes the local VersionOverride to rely on central package management. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
|
Ah yes, we should also set the |
Good grief. I'll look at the resolution chain and work out what's the best way to tackle this |
The OpenAPI package version was only bumped locally in one example project, creating drift from central package management. This change moves the upgrade to central package definitions so all projects resolve the same OpenAPI version.
Global package management
Directory.Packages.props:Microsoft.AspNetCore.OpenApi:8.0.20→10.0.10Local override cleanup
VersionOverrideinexamples/surrealdb/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService.csprojso it now inherits the centrally managed version.Resulting dependency shape