Make response file name prefix configurable#594
Open
larry-cdn77 wants to merge 1 commit into
Open
Conversation
Stale files can get large and need cleaning up, then it helps to have a descriptive name (rather than just 'tmp')
larry-cdn77
force-pushed
the
tmp-file-prefix
branch
from
9c411d3 to
ee42c3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stale files can get large and need cleaning up, then it helps to have a descriptive name (rather than just 'tmp')
Maybe the only kink is having to specify the prefix for each configured cache; it could be a global option (so that the cache YAML section does not break compatibilty) but then the ability to distinguish caches by prefixes could actually find some uses?
Checklist
Linter passed on all of the modified code
Also hand tested by watching /tmp using inotifywait, with and without tmp_file_prefix configured
Documentation is machine-generated, I thought it was quite good as it came out
Does this introduce a breaking change?
Default prefix changes from "tmp" to "chproxyTmp" – suspect if mentioned in release notes this need not be seen as an incompatibility?
Further comments
Related to #285