Repository navigation
[board] Record views and feedback results without the events consent - #333
Closed
arifBurakDemiray wants to merge 1 commit into
Closed
arifBurakDemiray wants to merge 1 commit into
arifBurakDemiray wants to merge 1 commit into
Conversation
Dependency security scanScanned 25 resolved dependencies, failing on HIGH and above. Result: passed |
Code coverage
Files changed by this pull request
Least covered classes (10 shown)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Card C-141: Bring R53 Internal (feature) events recorded regardless of the "events" consent to the Java SDK
Why: views and feedback widget results go through the events module, so without
Config.Feature.Eventsand its consent they are dropped, while Android, iOS and HarmonyOS record them under their own consent (parity R53).Change:
ModuleEventsis always built: a view needs only the views consent, a feedback result only the feedback consent.ModuleBase.featureRuns()); custom events stored by an earlier run wait for it and do not count toward the queue threshold.Countly.isTracking(Events)andevents()behave as before.Decided:
ModuleEvents.internalEventConsents,isReservedEvent).events().recordEvent("[CLY]_view")still needs the events consent. Android checks the key's own consent there; rejected, as it would drop those calls from apps that enable only Events.! Minor breaking change !, as more data is sent for the same consents (Android and iOS shipped it unflagged).Checked: 13 new scenario tests, 4 of them against a localhost mock Countly server (views, feedback, a restart with stored custom events, a 500 answer); the 11 behaviour tests each failed first for the expected reason, 2 guards (feedback with only the events consent, content events) pass before and after. Plus an
EventQueue.taketest, and 3 tests that asserted the old drop updated.:sdk-java:buildon Java 8: 758 pass. Two code review passes added the custom event gate inrecordEventInternal, theTimedEvents.restoreguard, the threshold count, the opt-out purge, the previous event ID reset and a null-safeSDKCore.enabled; simplify replaced Events special cases withfeatureRuns()andEventQueue.take/count; security review found nothing (feedback answers are no longer logged at info level).Not checked:
sdk-java-uitests: compiled only; the module is untouched, and 2 JavaFX toolkit tests timed out in the one run on this machine.