Skip to content

merge(contributing): set how plans prove gates and route reviews - #11

Closed
LittleCoinCoin wants to merge 3 commits into
mainfrom
docs/plans-gates-reviews
Closed

LittleCoinCoin wants to merge 3 commits into
mainfrom
docs/plans-gates-reviews

Conversation

@LittleCoinCoin

Copy link
Copy Markdown
Member

Summary

  • What this does. It sets how a plan proves its gates, how many verifiers a milestone runs, and where a review's findings outside the diff go. The rules are in a new AGENTS.md section, Plans, gates and reviews. It also files the three remaining items from the v1 review's code-gap campaign in the milestones that already edit that code. It changes no code.
  • The rules:
    • A gate shows its failure first. Each gate command is run on the tree before the change, and the plan records the failure it shows there. A gate that already passes before the change tests nothing.
    • A mechanism finds the sites. A change to every site of a pattern names what finds the sites: a lint, a git grep gate or a type. Sites are not counted by hand. A pattern that is open-ended or has come back gets such a mechanism; a single instance is fixed where it is.
    • Verification is per milestone. One spec-verifier pass and one Grit review of the whole diff run before the milestone's pull request. A leaf gets a Grit review only when it adds or changes a pub item. Adversarial verification stays wherever a leaf asks for it.
    • A review stays on the diff. Outside the diff, a reviewer reports defects only. Any other finding outside the diff is one line in the next milestone that edits that code. It gets no pull request of its own.
  • Where the remaining items go:
    • M4: merging FrameMode into Framing, and renaming Session::parent_session while keeping its wire name. M4's A3 work already moves the harness and trace types.
    • M3: deciding which targets Candler builds for. The cfg(not(unix)) stub of evaluate compiles on no target CI builds, and M3 is the milestone that reworks evaluate.

Test plan

  • dirtree-rdm validate passes on the amended level.
  • cog check passes on every commit, and every subject is at most 72 characters.
  • Only AGENTS.md and two leaves under __roadmap__/ change. This PR's AGENTS.md change is in a different part of the file from merge(isolation): close the v1 review's three code gaps #10's, and neither depends on the other.

🤖 Generated with Claude Code

LittleCoinCoin and others added 3 commits November 10, 2026 11:21
A gate is run on the tree before the change and must fail there. A
change to every site of a pattern names the mechanism that finds the
sites. Verification runs once per milestone, with the Grit reviewer on a
leaf only when it touches a pub item. A finding outside the diff that is
not a defect goes to the milestone that next edits that code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@LittleCoinCoin LittleCoinCoin changed the title merge(contributing): set how plans prove gates and where reviews go merge(contributing): set how plans prove gates and route reviews Nov 10, 2026
@LittleCoinCoin

Copy link
Copy Markdown
Member Author

Superseded by #12, which keeps only the two roadmap commits. The AGENTS.md section was ruled out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant