Repository navigation
merge(release): keep a schemas release to the schemas crate - #13
Merged
Merged
Conversation
release-plz gives a commit's bump to every crate whose files it touches. a452385 (`refactor(repo)!`) added one deny line to the schemas crate, so its breaking marker, meant for the core, took the schemas line to 0.5.0 when its own commits called for a patch. release-plz has no per-package commit filter: `release_commits` is read from [workspace] only, and the custom increment regexes can raise a bump, never lower it. The commit check now refuses a release-triggering commit that touches crates/candler-schemas/ unless it is scoped `schemas` and touches no other crate under crates/. Files outside crates/, such as Cargo.lock, belong to no package and stay allowed. The regex is read from release-plz.toml, so the check and the release cannot disagree on what releases. Merge commits are skipped; their branch commits are checked on the pull request. Over main's history it flags a452385, ab3623c, f7424de and de65a19, the four commits that released the schemas line together with another crate or under another scope. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
release-plz releases the schemas line on any change under crates/candler-schemas/, the Rust types included, not on the schema files alone, so the Versioning table now says the line covers the crate. The rule for commits follows from how release-plz attributes a commit, and the Enforcement table lists the CI check that holds it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a452385 refactor(repo)!. That commit added one deny line tocrates/candler-schemas/src/lib.rs. release-plz gives a commit's bump to every crate whose files it touches, so the commit's breaking marker, meant for the core, reached the schemas line too. The schemas crate's own commit (46269bd refactor(schemas)) called for a patch. schemas@0.5.0 stays as released.release_commitscan only be set under[workspace]. The per-packagecustom_*_increment_regexfields can make a bump bigger but never smaller.release_commitsfromrelease-plz.toml. It refuses a release-triggering commit that touchescrates/candler-schemas/unless the commit has scopeschemasand touches no other crate undercrates/. Root files such asCargo.lockbelong to no package and are still allowed. Merge commits are skipped. It runs on the same range ascog check.Test plan
a452385,ab3623candf7424de, and passes on46269bd refactor(schemas),0fef75f test(jobs)and118f1ea chore(release).a452385,ab3623c,f7424deandde65a19 docs(readme).cog check origin/main..HEADpasses. Neither commit triggers a release.🤖 Generated with Claude Code