Skip to content

merge(release): keep a schemas release to the schemas crate - #13

Merged
LittleCoinCoin merged 2 commits into
mainfrom
ci/schemas-release-alone
Nov 10, 2026
Merged

LittleCoinCoin merged 2 commits into
mainfrom
ci/schemas-release-alone

Conversation

@LittleCoinCoin

Copy link
Copy Markdown
Member

Summary

  • Why. schemas@0.5.0 came from a452385 refactor(repo)!. That commit added one deny line to crates/candler-schemas/src/lib.rs. release-plz gives a commit's bump to every crate whose files it touches, so the commit's breaking marker, meant for the core, reached the schemas line too. The schemas crate's own commit (46269bd refactor(schemas)) called for a patch. schemas@0.5.0 stays as released.
  • release-plz cannot express the rule itself. release_commits can only be set under [workspace]. The per-package custom_*_increment_regex fields can make a bump bigger but never smaller.
  • The check. A new step in the "Commit messages" job reads release_commits from release-plz.toml. It refuses a release-triggering commit that touches crates/candler-schemas/ unless the commit has scope schemas and touches no other crate under crates/. Root files such as Cargo.lock belong to no package and are still allowed. Merge commits are skipped. It runs on the same range as cog check.
  • CONTRIBUTING. The Versioning table now says the schemas line covers the whole crate, the Rust types included. The commit rule is stated the way release-plz applies it, and the Enforcement table lists the check.

Test plan

  • Run alone on single commits: it fails on a452385, ab3623c and f7424de, and passes on 46269bd refactor(schemas), 0fef75f test(jobs) and 118f1ea chore(release).
  • Run on ranges: it fails on PR merge(isolation): close the v1 review's three code gaps #10's range, passes on PR merge(runner): file the v1 review's last items under m3 and m4 #12's, and behaves the same on a first push and on a pull-request event.
  • Run over all of main's history: it flags exactly the four commits that released the schemas line together with another crate or under another scope: a452385, ab3623c, f7424de and de65a19 docs(readme).
  • cog check origin/main..HEAD passes. Neither commit triggers a release.
  • CI on this PR.

🤖 Generated with Claude Code

LittleCoinCoin and others added 2 commits November 10, 2026 13:19
release-plz gives a commit's bump to every crate whose files it
touches. a452385 (`refactor(repo)!`) added one deny line to the
schemas crate, so its breaking marker, meant for the core, took the
schemas line to 0.5.0 when its own commits called for a patch.
release-plz has no per-package commit filter: `release_commits` is
read from [workspace] only, and the custom increment regexes can raise
a bump, never lower it.

The commit check now refuses a release-triggering commit that touches
crates/candler-schemas/ unless it is scoped `schemas` and touches no
other crate under crates/. Files outside crates/, such as Cargo.lock,
belong to no package and stay allowed. The regex is read from
release-plz.toml, so the check and the release cannot disagree on
what releases. Merge commits are skipped; their branch commits are
checked on the pull request.

Over main's history it flags a452385, ab3623c, f7424de and de65a19,
the four commits that released the schemas line together with another
crate or under another scope.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
release-plz releases the schemas line on any change under
crates/candler-schemas/, the Rust types included, not on the schema
files alone, so the Versioning table now says the line covers the
crate. The rule for commits follows from how release-plz attributes a
commit, and the Enforcement table lists the CI check that holds it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@LittleCoinCoin LittleCoinCoin changed the title merge(release): refuse a schemas release that touches another crate merge(release): keep a schemas release to the schemas crate Nov 10, 2026
@LittleCoinCoin
LittleCoinCoin merged commit b017d31 into main Nov 10, 2026
4 of 8 checks passed
@LittleCoinCoin
LittleCoinCoin deleted the ci/schemas-release-alone branch November 10, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant