Rewrite privilage token middleware to be more efficent and use big.Int#90
Draft
KevinJoiner wants to merge 3 commits intomainfrom
Draft
Rewrite privilage token middleware to be more efficent and use big.Int#90KevinJoiner wants to merge 3 commits intomainfrom
KevinJoiner wants to merge 3 commits intomainfrom
Conversation
elffjs
reviewed
May 12, 2025
| type CustomClaims struct { | ||
| ContractAddress common.Address `json:"contract_address"` | ||
| TokenID string `json:"token_id"` | ||
| TokenID *big.Int `json:"token_id"` |
Member
There was a problem hiding this comment.
note: On the face of it, this is not backwards-compatible and probably dangerous in JS environments.
On the other hand we don't have any JS code that reads this right now and the tokens don't last very long. But we'd want to roll out upgrades to all affected services fairly quickly. (Or support both formats somehow).
elffjs
reviewed
May 12, 2025
| } | ||
| if claims.ContractAddress != v.Contract { | ||
| logger.Debug(). | ||
| Uint64(logfields.VehicleTokenID, tokenID.Uint64()). |
Member
There was a problem hiding this comment.
But this is not necessarily a vehicle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the privilege token middle ware because I was in there to fix big.Int and some other parts bothered me