fix: getCAs and CRLs unsetting X509_CERT_DIR#8503
fix: getCAs and CRLs unsetting X509_CERT_DIR#8503aldbr merged 2 commits intoDIRACGrid:integrationfrom
Conversation
|
Probably needing DIRACGrid/management#70 |
|
Just for my education: what's the point of unsetting the X509 variable ? |
IIRC it's only for pilots, and for the case when a release is installed (not taken from CVMFS): not being "polluted" by an existing environment variable pointing to a possibly not-updated locations. |
| elif command -v python3 &>/dev/null; then | ||
| py='python3' | ||
| elif command -v python2 &> /dev/null; then | ||
| elif command -v python2 &>/dev/null; then |
There was a problem hiding this comment.
Fine here but for next PRs: can we avoid that kind of formatting changes unrelated with the PRs please?
| "/entrypoint.sh", | ||
| "python", | ||
| "-c", | ||
| "import requests; requests.get('http://localhost:8000/.well-known/openid-configuration').raise_for_status()", |
There was a problem hiding this comment.
Here for instance, it's taking me some time to figure out whether you changed that line or whether it's just a formatting change (I assume it's just formatting here).
But aren't you updating a location that will never be used, given you set again the X509* ? |
|
The DIRAC's specific locations will always be looked up before the other ones, including those set by X509* variables. |
5 participants
closes #8501
BEGINRELEASENOTES
*Framework
FIX: getCAs and CRLs unsetting X509_CERT_DIR
ENDRELEASENOTES