Skip to content

Fix: do not need storage management db#8515

Open
fstagni wants to merge 3 commits intoDIRACGrid:integrationfrom
fstagni:fix_doNotNeedStorageManagementDB2
Open

Fix: do not need storage management db#8515
fstagni wants to merge 3 commits intoDIRACGrid:integrationfrom
fstagni:fix_doNotNeedStorageManagementDB2

Conversation

@fstagni
Copy link
Copy Markdown
Contributor

@fstagni fstagni commented Apr 14, 2026

BEGINRELEASENOTES

*WMS
FIX: Do not require StorageManagementDB to be there

ENDRELEASENOTES

@fstagni fstagni requested a review from atsareg as a code owner April 14, 2026 08:01
@fstagni fstagni force-pushed the fix_doNotNeedStorageManagementDB2 branch from 01377d7 to 4c02ebf Compare April 14, 2026 08:02
@aldbr aldbr requested review from chaen and removed request for atsareg April 14, 2026 08:21
@fstagni fstagni force-pushed the fix_doNotNeedStorageManagementDB2 branch 2 times, most recently from 456f456 to c4fa3bd Compare April 14, 2026 09:20
Comment thread src/DIRAC/TransformationSystem/Agent/TransformationCleaningAgent.py
Comment thread src/DIRAC/WorkloadManagementSystem/Agent/JobCleaningAgent.py
Comment thread src/DIRAC/WorkloadManagementSystem/Agent/StalledJobAgent.py
Comment thread src/DIRAC/WorkloadManagementSystem/Service/JobManagerHandler.py
)
if not result["OK"]:
return result
storagemanagementdb = result["Value"]()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does happen here if an exception is raised?

Copy link
Copy Markdown
Contributor Author

@fstagni fstagni Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a real exception, which I think it makes sense that it is propagated: if that happens it means that:

  • there are jobs in Staging status (which can only be set by the StorageManagementSystem)
  • The StorageManagementDB is removed.

I do not see how this could ever happen, unless someone installs the StorageManagementSystem only to remove it later.

Comment thread src/DIRAC/WorkloadManagementSystem/Agent/test/Test_Agent_JobCleaningAgent.py Outdated
Comment thread src/DIRAC/WorkloadManagementSystem/Agent/test/Test_Agent_JobCleaningAgent.py Outdated
Comment thread src/DIRAC/WorkloadManagementSystem/Service/JobManagerHandler.py
Comment thread src/DIRAC/WorkloadManagementSystem/Service/JobManagerHandler.py Outdated
@fstagni fstagni force-pushed the fix_doNotNeedStorageManagementDB2 branch from c4fa3bd to 48fbd55 Compare April 15, 2026 15:46
@fstagni fstagni force-pushed the fix_doNotNeedStorageManagementDB2 branch from 48fbd55 to df38096 Compare April 15, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants