Repository navigation
Conversation
fstagni
marked this pull request as ready for review
November 13, 2026 15:13
- docker and update-charts get explicit result checks, so a skipped release-please no longer skips them on PRs, schedule and dispatch. - docker checks out the release tag: the image build copies .git and hatch-vcs otherwise versions release images as 0.1.devN. - docker needs a successful publish on releases, so images and the chart bump are not pushed while the PyPI upload awaits approval or failed. - concurrency moves from the workflow to the release-please and publish jobs, so a publish waiting for approval does not hold later pushes. - publish uses skip-existing so a re-publish after a partial upload works. - build does not treat a failed release-please as "not a release". - a dispatched tag must be a v* tag on the checked-out commit. Assisted-by: Claude:claude-opus-5-5
9 of 24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to DIRACGrid/intercede#41 and DIRACGrid/signurlarity#66, part of DIRACGrid/.github#5 (PyPI releases bullet).
deployment.ymlandrelease-please.ymlare merged into a singledeployment.yml, because tags created withGITHUB_TOKENtrigger no workflows, so the publish has to happen in the same run that creates the release:release-please.ymlis deleted; itsrelease-pleasejob (now using the defaultGITHUB_TOKENinstead ofMY_RELEASE_PLEASE_TOKEN) and itsrelease-envjob (diracx.env release asset) move intodeployment.yml.deployment.ymltriggers on push tomain(replacing thev*tag trigger) and gains aworkflow_dispatchinput to re-publish an existing tag after a failed publish.deploy-pypiis split intobuild(no special permissions) andpublish(environmentpypi,id-token: write, trusted publishing, PEP 740 attestations). The overly broad permissions block of the olddeploy-pypijob is reduced to what is actually needed.dockerandupdate-chartsare unchanged apart from following thedeploy-pypi→buildrename.Required follow-ups before the next release (manual):
pypienvironment on this repository (no reviewers needed)diracx*package to reference workflowdeployment.ymlwith environmentpypi(previously no environment was set)