Skip to content

feat: Implement PilotAgents schema#292

Merged
aldbr merged 13 commits intoDIRACGrid:mainfrom
martynia:janusz_pilotDB
Oct 15, 2024
Merged

feat: Implement PilotAgents schema#292
aldbr merged 13 commits intoDIRACGrid:mainfrom
martynia:janusz_pilotDB

Conversation

@martynia
Copy link
Contributor

@martynia martynia commented Sep 11, 2024

This PR (along with #112 is necessary to be able to get pilot ID from a pilot stamp in pilot logging code (#269). It only implements the DB schema and a method to store pilot references in it.

  • Add PilotAgents related tables. Add PilotAgentsDB to pyproject.toml.
  • create addPilotReferences in db.py
  • add a unit test

@martynia martynia marked this pull request as draft September 11, 2024 09:08
@martynia martynia marked this pull request as ready for review October 4, 2024 08:51
@martynia martynia requested a review from aldbr October 7, 2024 14:10
Copy link
Contributor

@aldbr aldbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost fine, I am just curious about executemany versus execute n times.

@aldbr aldbr merged commit b11f378 into DIRACGrid:main Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants