Feature: OpenFOAM reader [1/n] - First structure#2256
Feature: OpenFOAM reader [1/n] - First structure#2256sandro-elsweijer wants to merge 13 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2256 +/- ##
==========================================
- Coverage 82.57% 81.87% -0.71%
==========================================
Files 116 117 +1
Lines 18553 18712 +159
==========================================
Hits 15320 15320
- Misses 3233 3392 +159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
spenke91
left a comment
There was a problem hiding this comment.
Thanks a lot for this feature @sandro-elsweijer ! I really like the code structure and style 👍 I do have some remarks, though, most of them being minor issues...
I went through the code, but did not run the example myself yet, since I did not have an OpenFOAM case readily available and would argue that we should add an example case anyway 😇
Co-authored-by: spenke91 <thomas.spenke@dlr.de>
d31c0e0 to
f6d0397
Compare
spenke91
left a comment
There was a problem hiding this comment.
Thanks for the update! The code changes all look good to me.
I will test the reader later today with the example case -- and then most probably give you a green light 🟢
Closes #2257
Describe your changes here:
Implements a first structure of the OpenFOAM reader.
The first draft of the OpenFOAM reader struct reads the files inside an OpenFOAM case and fills internal data structures.
The conversion of this data into a cmesh follows in the next PRs. Otherwise this PR would be too big to review.
The reader is not inside cmesh/IO/OpenFOAM, since the reader will not only provide a cmesh, but also a forest with data. So there is no clear distinction between the reader cmesh and forest and the OpenFOAM functionality is its own category.
This PR also implements an OpenFOAM example and it has two purposes:
There is no test yet, since the OpenFOAM reader is not finished yet. I plan to implement two tests:
Both tests can only be written, when the reader is finished.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).