Skip to content

Feature: Reintroduce FetchContent#2303

Merged
sandro-elsweijer merged 41 commits into
mainfrom
reintroduce_fetchcontent
May 20, 2026
Merged

Feature: Reintroduce FetchContent#2303
sandro-elsweijer merged 41 commits into
mainfrom
reintroduce_fetchcontent

Conversation

@sandro-elsweijer
Copy link
Copy Markdown
Member

@sandro-elsweijer sandro-elsweijer commented Apr 30, 2026

Closes #2304

Describe your changes here:
Reintroduces FetchContent after its removal in #2289

Improvements in this PR:

  • MakeAvailable was called multiple times for each target
  • Renamed dependencies to thirdparty, because not all libs in fetchcontent are mandatory
  • Combined fixes for SC and GTest
  • Fixed Gtest fix for Windows systems
  • Fixed CI
  • Marked some variables as internal instead of advanced
  • removed git_progress, because the output was too long and cmake truncated it

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the scripts/internal/find_all_source_files.sh to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@sandro-elsweijer sandro-elsweijer force-pushed the reintroduce_fetchcontent branch from 9b6430f to 762093d Compare April 30, 2026 11:06
@sandro-elsweijer sandro-elsweijer force-pushed the reintroduce_fetchcontent branch from 970b2cf to 254c5d5 Compare April 30, 2026 13:00
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.57%. Comparing base (7c121bf) to head (2b91986).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2303   +/-   ##
=======================================
  Coverage   82.57%   82.57%           
=======================================
  Files         116      116           
  Lines       18553    18553           
=======================================
  Hits        15320    15320           
  Misses       3233     3233           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandro-elsweijer sandro-elsweijer marked this pull request as ready for review May 4, 2026 13:16
Copy link
Copy Markdown
Collaborator

@benegee benegee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

From what I can tell, this looks good so far!

Comment thread NEWS.md Outdated
Comment thread .github/workflows/test_preparation.yml Outdated
Comment thread .github/workflows/testsuite.yml Outdated
Comment thread cmake/thirdparty.cmake Outdated
Comment thread cmake/thirdparty.cmake Outdated
Comment thread cmake/thirdparty.cmake Outdated
Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt
Copy link
Copy Markdown
Collaborator

@benegee benegee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benegee benegee assigned sandro-elsweijer and unassigned benegee May 20, 2026
@sandro-elsweijer sandro-elsweijer added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit 5c1e9cb May 20, 2026
26 checks passed
@sandro-elsweijer sandro-elsweijer deleted the reintroduce_fetchcontent branch May 20, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Reintroduce FetchContent

2 participants