Conversation
Member
|
Before a PR, especially a complicated one that adds unneeded 3rd party dependencies, let's start with a discussion (in the Discussion section) describing the problem you have. On some operating system (which one?) with network interfaces configured with IPv6 only, |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR allows multiple netprobe addresses, to better support IPv6-only, and IPv4-only networks with the same config.
all probes are run concurrently. the first one to succeed cancels the others and causes the main function to stop waiting.
dialer.DialContextwith the inputhost:portpair directly instead of resolving to*net.UDPAddr, this means it will try to resolve the host each time and try to dial any IPs that instead of resolving to just 1 which should improve compatibility with anything that templates/changes the hosts file or any hosts file entries with multiple IPs (i did test and it will resolve from/etc/hosts)retriedwith better support for specific messages like name resolution errors)netprobe_timeout: it's now tracked with a deadline instead of assuming each iteration is exactly 1sP.S. i also didn't commit any of
./vendorfor this PRIPv4 disabled example:
just [
9.9.9.9:53]:with [
[2620:fe::fe]:53,9.9.9.9:53]: