Add missing NgIf and NgFor imports to AuthorizedItemSelectorComponent (8x)#5136
Merged
tdonohue merged 1 commit intoDSpace:dspace-8_xfrom Feb 20, 2026
Merged
Conversation
tdonohue
approved these changes
Feb 20, 2026
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thank you @toniprieto for catching this mistake. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
During the backport of version x8 of #4918, two imports (
NgIfandNgFor) were missing.These were not needed in version 7x because it doesn’t use standalone components, and not required in
mainanddspace-9_xdue to the use of the new Angular control flow syntax.This PR simply adds the missing imports.
Instructions for Reviewers
To verify, open the item edit selector and check that it correctly lists the items available for editing.
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.