Skip to content

Comments

Add missing NgIf and NgFor imports to AuthorizedItemSelectorComponent (8x)#5136

Merged
tdonohue merged 1 commit intoDSpace:dspace-8_xfrom
toniprieto:missing-imports-8x
Feb 20, 2026
Merged

Add missing NgIf and NgFor imports to AuthorizedItemSelectorComponent (8x)#5136
tdonohue merged 1 commit intoDSpace:dspace-8_xfrom
toniprieto:missing-imports-8x

Conversation

@toniprieto
Copy link
Contributor

References

Description

During the backport of version x8 of #4918, two imports (NgIf and NgFor) were missing.
These were not needed in version 7x because it doesn’t use standalone components, and not required in main and dspace-9_x due to the use of the new Angular control flow syntax.
This PR simply adds the missing imports.

Instructions for Reviewers

To verify, open the item edit selector and check that it correctly lists the items available for editing.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge labels Feb 20, 2026
@tdonohue tdonohue modified the milestones: 9.3, 8.4 Feb 20, 2026
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you @toniprieto for catching this mistake. Looks good to me.

@tdonohue tdonohue merged commit a75c7d8 into DSpace:dspace-8_x Feb 20, 2026
18 of 19 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace Maintenance (9.x, 8.x, 7.6.x) Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug

Projects

Development

Successfully merging this pull request may close these issues.

2 participants