Skip to content

DURACOM-441 Provided fallback logic for page search, we now fallback to the highest available totalPages if we reach an out of bound search page#5485

Open
Sondissimo wants to merge 1 commit intoDSpace:mainfrom
4Science:task/main/DURACOM-441
Open

DURACOM-441 Provided fallback logic for page search, we now fallback to the highest available totalPages if we reach an out of bound search page#5485
Sondissimo wants to merge 1 commit intoDSpace:mainfrom
4Science:task/main/DURACOM-441

Conversation

@Sondissimo
Copy link
Copy Markdown
Contributor

@Sondissimo Sondissimo commented Apr 15, 2026

Description

Provided fallback logic for page search, we now fallback to the highest available totalPages if we reach an out of bound search page
The practical use case for it can be described by this example: "I copy a link to the last page of a search with a single result; in the meantime, an item related to the same search is deleted — at that point, the link leads to an empty page."

Instructions for Reviewers

Implemented a fallback logic when reaching out of bounds pages

List of changes in this PR:

  • Implemented fallback logic
  • Provided tests

Include guidance for how to test or review your PR.

In homepage run a search, go to the highest available page, go up one more and the fallback pagination logic will be triggered and you will be brought back to the highest available page

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

…to the highest available totalPages if we reach an out of bound page
@Sondissimo Sondissimo marked this pull request as ready for review April 16, 2026 07:53
@lgeggleston lgeggleston added improvement usability component: Discovery related to discovery search or browse system labels Apr 16, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: Discovery related to discovery search or browse system improvement usability

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

2 participants