DURACOM-441 Provided fallback logic for page search, we now fallback to the highest available totalPages if we reach an out of bound search page#5485
Open
Sondissimo wants to merge 1 commit intoDSpace:mainfrom
Conversation
…to the highest available totalPages if we reach an out of bound page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provided fallback logic for page search, we now fallback to the highest available totalPages if we reach an out of bound search page
The practical use case for it can be described by this example: "I copy a link to the last page of a search with a single result; in the meantime, an item related to the same search is deleted — at that point, the link leads to an empty page."
Instructions for Reviewers
Implemented a fallback logic when reaching out of bounds pages
List of changes in this PR:
Include guidance for how to test or review your PR.
In homepage run a search, go to the highest available page, go up one more and the fallback pagination logic will be triggered and you will be brought back to the highest available page
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.