Improve placeholder text / form UX in Browse By "Starts with" form control

[kshepherd]

References

• Fixes Browsing by Author returns no results for valid author search term #5495

Description

The placeholder text in the browse-by input form was misleading, with a value of "Search the repository".
This small change shifts the hint text into the form placeholder, instead of being displayed as a small non-obvious line of text below the input form control.

The hint text is already translated across many languages, so it is not text I had to come up with myself and request help from translators.

I think this is improved UX. Feedback welcome.

Instructions for Reviewers

Simply compare the form display when you visit "Browse by Author", with and without this change applied.

List of changes in this PR:

• Replace the i18n key browse.search-form.placeholder in the starts-with Angular component, with browse.startsWith.type_text
• Remove the small hint text element from below the form input control, as it is now displayed as placeholder text
• Remove the (now) unused browse.search-form.placeholder key

Checklist

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR fixes an issue ticket, I've linked them together.

[EikLoe]

Hi @kshepherd ,
I tested it and it works great! Thanks 👍🏾 The code looks good to me!

[EikLoe]

We might consider backporting this, as it appears in demo.dspace.org, too.

[lgeggleston]

Good point! Adding labeling for all automatic backports, in case it works out for previous versions.