Skip to content

Fixed Scala classpath inference for scalikejdbc-3.5 in IDEA sync.#11601

Open
AlexeyKuznetsov-DD wants to merge 2 commits into
masterfrom
alexeyk/scalikejdbc-idea-fix
Open

Fixed Scala classpath inference for scalikejdbc-3.5 in IDEA sync.#11601
AlexeyKuznetsov-DD wants to merge 2 commits into
masterfrom
alexeyk/scalikejdbc-idea-fix

Conversation

@AlexeyKuznetsov-DD

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Adds compileOnly libs.scala to the :dd-java-agent:instrumentation:jdbc:scalikejdbc-3.5 module and regenerates its gradle.lockfile.

Motivation

To fix error in IDEA during re-sync of Gradle project:

org.gradle.api.GradleException: Cannot infer Scala class path because no Scala library Jar was found.
Does project ':dd-java-agent:instrumentation:jdbc:scalikejdbc-3.5' declare dependency to scala-library?

Putting scala-library on the main compile classpath via compileOnly lets IDEA resolve the Scala runtime.

Additional Notes

  • compileOnly keeps scala-library out of the published artifact — Scala sources only exist under src/test.
  • Lockfile regenerated since the main compileClasspath changed.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested a review from bric3 June 8, 2026 22:27
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Jun 8, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added type: bug Bug report and fix tag: no release notes Changes to exclude from release notes inst: jdbc JDBC instrumentation inst: scala Scala instrumentation labels Jun 8, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD marked this pull request as ready for review June 8, 2026 22:27
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested a review from a team as a code owner June 8, 2026 22:27
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from vandonr and removed request for a team June 8, 2026 22:27
@datadog-datadog-prod-us1

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.94 s 13.95 s [-1.3%; +1.2%] (no difference)
startup:insecure-bank:tracing:Agent 12.74 s 12.98 s [-3.0%; -0.6%] (maybe better)
startup:petclinic:appsec:Agent 16.79 s 16.77 s [-1.2%; +1.5%] (no difference)
startup:petclinic:iast:Agent 16.84 s 16.88 s [-1.3%; +0.9%] (no difference)
startup:petclinic:profiling:Agent 16.82 s 16.83 s [-1.6%; +1.4%] (no difference)
startup:petclinic:sca:Agent 16.76 s 16.59 s [-0.5%; +2.5%] (no difference)
startup:petclinic:tracing:Agent 15.87 s 16.08 s [-2.6%; -0.0%] (maybe better)

Commit: 4924b2f5 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: jdbc JDBC instrumentation inst: scala Scala instrumentation tag: no release notes Changes to exclude from release notes type: bug Bug report and fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant