Skip to content

Optimize collection creation and memory allocation of supported config#11616

Open
PerfectSlayer wants to merge 1 commit into
masterfrom
bbujon/generated-config
Open

Optimize collection creation and memory allocation of supported config#11616
PerfectSlayer wants to merge 1 commit into
masterfrom
bbujon/generated-config

Conversation

@PerfectSlayer

Copy link
Copy Markdown
Contributor

What Does This Do

This PR removes collection creation and array allocation when not needed:

  • Arrays.asList() - no param - to Collections.emptyList()
  • Collections.unmodifiableList(Arrays.asList()) - no param - to Collections.emptyList()
  • Arrays.asList(x) - a single item - to Collections.singletonList(x)
  • Collections.unmodifiableList(Arrays.asList(x)) - a single item - Collections.singletonList(x)

Motivation

Performance, memory allocation

Additional Notes

Also use imports for readability.

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer requested a review from a team as a code owner June 10, 2026 12:36
@PerfectSlayer PerfectSlayer added the type: enhancement Enhancements and improvements label Jun 10, 2026
@PerfectSlayer PerfectSlayer requested a review from ygree June 10, 2026 12:36
@PerfectSlayer PerfectSlayer added tag: performance Performance related changes comp: config Configuration labels Jun 10, 2026
@datadog-datadog-prod-us1

This comment has been minimized.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b26dea5cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@PerfectSlayer PerfectSlayer force-pushed the bbujon/generated-config branch from 0b26dea to fa8c3ca Compare June 10, 2026 12:50
@dd-octo-sts

dd-octo-sts Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.97 s 13.91 s [-0.5%; +1.4%] (no difference)
startup:insecure-bank:tracing:Agent 12.90 s 13.00 s [-1.4%; -0.0%] (maybe better)
startup:petclinic:appsec:Agent 16.84 s 16.60 s [+0.6%; +2.3%] (maybe worse)
startup:petclinic:iast:Agent 16.28 s 16.93 s [-7.8%; +0.1%] (no difference)
startup:petclinic:profiling:Agent 16.74 s 16.90 s [-1.8%; -0.1%] (maybe better)
startup:petclinic:sca:Agent 16.88 s 16.74 s [-0.1%; +1.8%] (no difference)
startup:petclinic:tracing:Agent 15.95 s 15.97 s [-1.1%; +1.0%] (no difference)

Commit: fa8c3cac · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

BitsAI couldn’t fix CI

BitsAI couldn’t produce a safe fix for this CI failure. Open the Datadog session to inspect the attempt or continue from there.

Progress

🟢 Investigated · 🔴 Fix failed · ⚪ Validate · ⚪ Ready


Commit: fa8c3ca

View session in Datadog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: config Configuration tag: performance Performance related changes type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants