Decouple FFE from Tracing proposal#11888
Conversation
leoromanovsky
left a comment
There was a problem hiding this comment.
Works for me, thanks!
There was a problem hiding this comment.
💡 Codex Review
https://github.com/DataDog/dd-trace-java/blob/d3f54ffd72a758ade9b021dafa6011be5b9147e1/dd-trace-api/src/main/java/datadog/trace/api/config/FeatureFlaggingConfig.java#L1
Preserve the old FeatureFlaggingConfig API
When a customer or external integration upgrades dd-trace-api and still imports datadog.trace.api.config.FeatureFlaggingConfig for these public config keys, deleting the class makes their source stop compiling; reflective/runtime lookups of the old class also fail. The replacement is in a new product module that dd-trace-api does not publish or depend on, so please keep a deprecated forwarding class in the old package (or provide another compatibility path) while moving internal users to the new module.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🎯 Code Coverage (details) 🔗 Commit SHA: 4b4b1c2 | Docs | Datadog PR Page | Give us feedback! |
I’m good with that. It’s experimental keys and I don’t want to add |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
What Does This Do
This PR introduces a dedicated module for FFE config.
This would avoid adding
:internal-apior:dd-trace-apiinto the:feature-flagging-apimodule and keep the separation between FFE and Tracing clean.Motivation
Configuration will be generated at some points from the JSON configuration.
This is an intermediate solution that will keep the FFE design clean.
Additional Notes
This PR is a change proposal as part of the review of #11658
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]