Skip to content

Migrate Scala test setup to a convention plugin - #12260

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
refactor/migrate-scala-test-convention
Aug 25, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
refactor/migrate-scala-test-convention

Conversation

@bric3

@bric3 bric3 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Replaces the shared Scala test script with the dd-trace-java.conventions.testing.scala convention and migrates its consumers.

Motivation

The name describes Scala test support. Groovy interoperability is configured only when the Groovy plugin is present.

Additional Notes

This convention lands in the preferred build-logic/ location because projects apply it directly, on demand. It could move to buildSrc/, but that is not the desired goal. Conventions should move there only when their types or plugins must be visible to other buildSrc/ plugins or legacy script plugins through Gradle’s shared build-script classloader.

@bric3 bric3 added comp: tooling Build & Tooling type: refactoring tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes labels Aug 21, 2026
@datadog-datadog-us1-prod

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.03 s 13.99 s [-0.6%; +1.2%] (no difference)
startup:insecure-bank:tracing:Agent 12.97 s 13.07 s [-1.7%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 16.91 s 16.72 s [+0.0%; +2.3%] (maybe worse)
startup:petclinic:iast:Agent 16.91 s 17.00 s [-1.4%; +0.4%] (no difference)
startup:petclinic:profiling:Agent 16.65 s 16.24 s [-2.0%; +7.1%] (no difference)
startup:petclinic:sca:Agent 16.81 s 16.40 s [+1.5%; +3.5%] (significantly worse)
startup:petclinic:tracing:Agent 15.57 s 16.13 s [-7.5%; +0.6%] (no difference)

Commit: 520bc915 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3
bric3 marked this pull request as ready for review August 21, 2026 16:49
@bric3
bric3 requested review from a team as code owners August 21, 2026 16:49
@bric3
bric3 requested review from jordan-wong and removed request for a team August 21, 2026 16:49

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The new convention keeps the prior Scala dependencies and Groovy compile setup. All former script users now use the convention.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 617a828 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

Preserve test runtime dependency selection and logger properties in the convention plugin.
@bric3
bric3 requested a review from a team as a code owner August 25, 2026 10:27
@bric3
bric3 requested review from PerfectSlayer and removed request for a team August 25, 2026 10:27
Move Scala test setup into a standalone convention. Configure Groovy interoperability only when the Groovy plugin is present.
@bric3
bric3 force-pushed the refactor/migrate-scala-test-convention branch from 617a828 to 520bc91 Compare August 25, 2026 10:29
Base automatically changed from refactor/migrate-slf4j-simple-convention to master August 25, 2026 12:14

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The new convention plugins preserve the removed scripts' dependencies, task setup, and logging setup. Each former user now applies the matching plugin.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 520bc91 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@bric3

bric3 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 25, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-25 15:00:20 UTC ℹ️ Start processing command /merge


2026-08-25 15:00:26 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-08-25 16:02:52 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit b9e3cf9 into master Aug 25, 2026
603 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the refactor/migrate-scala-test-convention branch August 25, 2026 16:02
@github-actions github-actions Bot added this to the 1.66.0 milestone Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants