Migrate Scala test setup to a convention plugin - #12260
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
More details
The new convention keeps the prior Scala dependencies and Groovy compile setup. All former script users now use the convention.
🤖 Datadog Autotest · Commit 617a828 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
Preserve test runtime dependency selection and logger properties in the convention plugin.
Move Scala test setup into a standalone convention. Configure Groovy interoperability only when the Groovy plugin is present.
617a828 to
520bc91
Compare
There was a problem hiding this comment.
More details
The new convention plugins preserve the removed scripts' dependencies, task setup, and logging setup. Each former user now applies the matching plugin.
🤖 Datadog Autotest · Commit 520bc91 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Replaces the shared Scala test script with the
dd-trace-java.conventions.testing.scalaconvention and migrates its consumers.Motivation
The name describes Scala test support. Groovy interoperability is configured only when the Groovy plugin is present.
Additional Notes
This convention lands in the preferred
build-logic/location because projects apply it directly, on demand. It could move tobuildSrc/, but that is not the desired goal. Conventions should move there only when their types or plugins must be visible to otherbuildSrc/plugins or legacy script plugins through Gradle’s shared build-script classloader.