Repository navigation
uploader: add opt-in persistent HTTP connections - #307
Open
tonyredondo wants to merge 2 commits into
Open
tonyredondo wants to merge 2 commits into
tonyredondo wants to merge 2 commits into
Conversation
tonyredondo
marked this pull request as ready for review
November 14, 2026 07:47
There was a problem hiding this comment.
More details
The completed static review found no reportable defect in the opt-in transport, including route isolation, retry limits, response handling, and worker cleanup.
🤖 Bits Code Review · Commit d411d08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The uploader currently opens a connection for every request. This adds optional connection reuse so consumers can compare that cost on their own intake and proxy routes. It stays off by default and is independent of test-payload batching.
Enable it with
http_keep_alive = Trueondd_payload_uploader, or setDD_TEST_OPTIMIZATION_HTTP_KEEP_ALIVE=1at runtime. Setting the variable to0restores the default transport. The Python uploader owns at most one connection per worker and closes it when the origin, proxy or tunnel changes, on incomplete responses or transport errors, and when the worker pool exits. Legacy Bash and PowerShell uploaders reject an enabled setting.TLS verification, proxy bypass, credentials, request bodies and the explicit retry budget retain their existing policy. A stale connection can fail after a POST reached the server; recovery uses that same retry budget and prepared body. Connection reuse adds no hidden reconnect retry or exactly-once guarantee.
Validation:
d411d08d, including CodeQL. The CI jobs checked out merge revision315d3eba, which contains this head andmain@95cf545a.git diff --checkpassed.A small loopback TLS comparison held 64 requests and 1,050,240 body bytes fixed and reduced accepted connections from 64 to one. It establishes reuse, not a throughput improvement for a real consumer. The paired E2E PR adds this comparison to the existing Linux WORKSPACE and Bzlmod jobs; there is no new job matrix.
Paired consumer coverage: rules_test_optimization_tests #194.