Open
Conversation
Contributor
|
|
🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: d668cb0 | Docs | Datadog PR Page | Give us feedback! |
e8fe632 to
c6f077a
Compare
b7f8af5 to
9e284f5
Compare
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
cbeauchesne
requested changes
May 7, 2026
| --progress=plain \ | ||
| -f utils/build/docker/proxy.Dockerfile \ | ||
| -t datadog/system-tests:proxy-v1 \ | ||
| -t datadog/system-tests:proxy-v2 \ |
Collaborator
There was a problem hiding this comment.
I don't think you need to update proxy image, the proxy code is mounted at rutime. As long as your using the same dependancies, it's fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Avoid forcing a decision on observing either TCP or UDP communication with the agent. We should be able to observe both. This was originally motivated by improvements to the post-setup process relying on arrival of flushed tracing data, which was not available in the RUNTIME_METRICS scenario.
It turns out it also uncovered an issue with a test for runtime metrics default in the DEFAULT scenario. The test was asserting that runtime metrics were not generated. It always passed because there was nothing listening to the DogStatsD UDP port.
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present