Skip to content

Verify compact OTLP histograms where consecutive empty buckets are collapsed#6837

Open
mcculls wants to merge 1 commit intomainfrom
mcculls/java-otlp-compact-histograms
Open

Verify compact OTLP histograms where consecutive empty buckets are collapsed#6837
mcculls wants to merge 1 commit intomainfrom
mcculls/java-otlp-compact-histograms

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented May 3, 2026

Motivation

The Java SDK exports OTLP histograms in a compact form where consecutive empty buckets are collapsed into a single bucket using the last boundary. This saves bandwidth when exporting histograms that have lots of explicit boundaries, but only a few of them have counts.

Changes

Creates a new assert_histogram_buckets method that correctly validates both non-compacted and compacted histogram buckets.

Also fixes an issue in the original test where the aggregation_temporality parameter was not actually tested due to shadowing.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

CODEOWNERS have been resolved as:

tests/parametric/test_otel_metrics.py                                   @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

@mcculls mcculls force-pushed the mcculls/java-otlp-compact-histograms branch from a9d5a09 to 896f2b5 Compare May 4, 2026 16:40
@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented May 4, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 80f21a8 | Docs | Datadog PR Page | Give us feedback!

@mcculls mcculls force-pushed the mcculls/java-otlp-compact-histograms branch 2 times, most recently from e524e4a to be4e0b2 Compare May 4, 2026 17:41
@mcculls mcculls marked this pull request as ready for review May 4, 2026 17:52
@mcculls mcculls requested review from a team as code owners May 4, 2026 17:52
@mcculls mcculls requested review from anna-git and zacharycmontoya and removed request for a team May 4, 2026 17:52
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be4e0b221b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread tests/parametric/test_otel_metrics.py Outdated
Comment thread tests/parametric/test_otel_metrics.py Outdated
@mcculls mcculls marked this pull request as draft May 5, 2026 12:22
@mcculls mcculls force-pushed the mcculls/java-otlp-compact-histograms branch 3 times, most recently from 6f7ccac to 91a7a3f Compare May 5, 2026 15:01
@mcculls mcculls marked this pull request as ready for review May 5, 2026 15:04
@mcculls mcculls requested a review from cbeauchesne May 5, 2026 15:04
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 91a7a3f699

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread tests/parametric/test_otel_metrics.py Outdated
@mcculls mcculls force-pushed the mcculls/java-otlp-compact-histograms branch 2 times, most recently from d65281d to afe44aa Compare May 5, 2026 15:24
@mcculls mcculls force-pushed the mcculls/java-otlp-compact-histograms branch from afe44aa to e4b1706 Compare May 5, 2026 15:41
may be collapsed into a single bucket with the last boundary.
@mcculls mcculls force-pushed the mcculls/java-otlp-compact-histograms branch from e4b1706 to 80f21a8 Compare May 5, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants