Verify compact OTLP histograms where consecutive empty buckets are collapsed#6837
Verify compact OTLP histograms where consecutive empty buckets are collapsed#6837
Conversation
|
|
a9d5a09 to
896f2b5
Compare
🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 80f21a8 | Docs | Datadog PR Page | Give us feedback! |
e524e4a to
be4e0b2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be4e0b221b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
6f7ccac to
91a7a3f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91a7a3f699
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
d65281d to
afe44aa
Compare
afe44aa to
e4b1706
Compare
may be collapsed into a single bucket with the last boundary.
e4b1706 to
80f21a8
Compare
Motivation
The Java SDK exports OTLP histograms in a compact form where consecutive empty buckets are collapsed into a single bucket using the last boundary. This saves bandwidth when exporting histograms that have lots of explicit boundaries, but only a few of them have counts.
Changes
Creates a new
assert_histogram_bucketsmethod that correctly validates both non-compacted and compacted histogram buckets.Also fixes an issue in the original test where the
aggregation_temporalityparameter was not actually tested due to shadowing.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present