Draft
Conversation
The test was marked irrelevant in every language manifest and has been replaced by Slack channel alerts. Remove the test, its two helper functions, the eight manifest entries, and the two JSON files (config_prefix_block_list.json, config_aggregation_list.json) that were exclusively loaded by it. Co-Authored-By: Claude Sonnet 4.6 (1M context) <[email protected]>
Leave config_prefix_block_list.json and config_aggregation_list.json in place — scope of this PR is only the test and manifest entries. Co-Authored-By: Claude Sonnet 4.6 (1M context) <[email protected]>
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
test_config_telemetry_completenessis no longer needed — it has been superseded by the config registry. DataDog/dd-trace-py#17875 adds config registry support to Python, which was the only language that still ran this test. All other languages had already marked itirrelevant("replaced by alerts on slack channels").Changes
test_config_telemetry_completenessfromtests/test_telemetry.py, along with the two helper functions (get_all_keys_and_values,is_key_accepted_by_telemetry) that were exclusively used by itirrelevantmanifest entries from:cpp_httpd.yml,cpp_nginx.yml,dotnet.yml,golang.yml,java.yml,nodejs.yml,php.yml,ruby.ymlThe JSON files in
utils/telemetry/intake/static/are left untouched —config_norm_rules.jsonand the per-language*_config_rules.jsonfiles are still used bytest_debugger_products_disabled.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present