Profiling to the Console functionality#3
Open
mhdshameel wants to merge 9 commits intoDefinitelyNotAnmol:masterfrom
Open
Profiling to the Console functionality#3mhdshameel wants to merge 9 commits intoDefinitelyNotAnmol:masterfrom
mhdshameel wants to merge 9 commits intoDefinitelyNotAnmol:masterfrom
Conversation
…tion Added polymorphism for printing profiling results to the console. And can be easily invoked with `START_CONSOLE_SESSION` instead of `START_SESSION`, no other configurations are required. The existing `Instrumentor` is updated to `FilestreamInstrumentor`.
Cant continue being a header only as there are static components that need to be initialized. If those are initialized in the header, they will get redefined errors if the header is used in multiple projects.
Fixed the issue of profiling happening before the START_BENCHMARK_SESSION. Throws an exception if the profiling is executed before start_benchmark_session is called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added polymorphism for printing profiling results to the console. And can be easily invoked with
START_CONSOLE_SESSIONinstead ofSTART_SESSION, no other configurations are required.The existing
Instrumentoris updated toFilestreamInstrumentor.Updated the readme as well.