fix(installer): accept legacy release archive layout - #1514
Conversation
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
|
Thank you for the installer compatibility patch and the clear link to the affected reports. I have routed it as a high-priority installer bug for the immediate train. The branch currently conflicts with |
|
Reviewed — thank you @cyphercodes. Same note as #1512: the failing check is Related: we're also shipping |
Signed-off-by: cyphercodes <cyphercodes@users.noreply.github.com>
3c8730e to
ee6abbe
Compare
|
Rebased on current Verification run locally:
|
What does this PR do?
Fixes #1510.
install.shnow accepts the exact legacy four-member release archive layout used by the published v0.9.0/v0.9.x assets, while still keeping the canonical current runtime-asset layouts closed:The installer continues to reject unexpected archive members, duplicate/missing required core members, malformed UI pack names, and UI pack digest mismatches. The smoke fixture contract now covers the legacy standard/UI layouts and canonical UI layout through a loopback HTTP installer fixture.
Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)Local verification run:
bash -n install.shbash -n tests/test_smoke_fixture_contract.shbash tests/test_smoke_fixture_contract.shCBM_DOWNLOAD_URL=https://github.com/DeusData/codebase-memory-mcp/releases/download/v0.9.0 bash ./install.sh --standard --skip-configwith a temporaryHOME, then installed binary--versionCBM_DOWNLOAD_URL=https://github.com/DeusData/codebase-memory-mcp/releases/download/v0.9.0 bash ./install.sh --ui --skip-configwith a temporaryHOME, then installed binary--versiongit diff --check HEAD~1..HEADscripts/check-dco.sh HEAD~1..HEAD