perf(index): bound parallel source retention for low RAM#685
Open
nguyentamdat wants to merge 1 commit into
Open
perf(index): bound parallel source retention for low RAM#685nguyentamdat wants to merge 1 commit into
nguyentamdat wants to merge 1 commit into
Conversation
Limit source retention to a fraction of the memory budget, skip retention when cross-file LSP is disabled or incremental indexing cannot use it, and fail cleanly on extract allocation failures. Verify: make -f Makefile.cbm test Signed-off-by: nguyentamdat <nguyentamdat@gmail.com>
nguyentamdat
force-pushed
the
low-ram-index-retention-pr
branch
from
4c38514 to
08319e8
Compare
Owner
|
Huge thanks for opening this PR and for the work you put into it. The maintainer shop is currently full, so this may sit for a bit before it gets a proper review. We will come back to this as soon as possible with real feedback; I wanted to make sure it did not sit unacknowledged in the meantime. |
DeusData
added
stability/performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retain_sources=falseVerification
make -f Makefile.cbm test->5728 passedNotes
Split out from #684 so the low-RAM indexing change is reviewed independently from the JVM callgraph fix.