Skip to content

Demos: DisableExternalEditor (codesandbox, etc.) from menuMeta.json (#33125)#33139

Open
mpreyskurantov wants to merge 1 commit intoDevExpress:26_1from
mpreyskurantov:26_1-33125
Open

Demos: DisableExternalEditor (codesandbox, etc.) from menuMeta.json (#33125)#33139
mpreyskurantov wants to merge 1 commit intoDevExpress:26_1from
mpreyskurantov:26_1-33125

Conversation

@mpreyskurantov
Copy link
Copy Markdown
Contributor

@mpreyskurantov mpreyskurantov commented Apr 2, 2026

@mpreyskurantov mpreyskurantov self-assigned this Apr 2, 2026
Copilot AI review requested due to automatic review settings April 2, 2026 15:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the demos metadata (apps/demos/menuMeta.json) to disable launching certain demos in external editors (CodeSandbox, etc.) via a new DisableExternalEditor flag, likely targeting demos that depend on backend/server infrastructure.

Changes:

  • Added DisableExternalEditor: true to multiple demo entries (DataGrid, CardView, Diagram, Scheduler, FileUploader, Localization).
  • Adjusted JSON object formatting (commas) to accommodate the new property.

Comment on lines +74 to +75
"DemoType": "Web",
"DisableExternalEditor": true
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DisableExternalEditor is added for the DataGrid “Web API Service”, but other demos in the same menuMeta.json that also rely on server-side backend files still don’t have this flag (e.g. “SignalR Service” around lines 88–93, “Remote CRUD Operations” around lines 315–329, “Remote Reordering” around lines 721–735). If the intent is to hide/disable external editors for demos that can’t run standalone, consider applying DisableExternalEditor: true consistently to all such entries (at least those with BackendFiles).

Copilot uses AI. Check for mistakes.
@@ -3530,7 +3540,8 @@
"SchedulerDataController.cs",
"InMemoryAppointmentsDataContext"
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Scheduler “Web API Service” demo, BackendFiles lists "InMemoryAppointmentsDataContext" without the .cs extension, while the same file is referenced as /Models/InMemoryAppointmentsDataContext.cs in MvcAdditionalFiles and most other BackendFiles entries use full filenames. This inconsistency can break tooling that links or copies backend files; consider changing it to InMemoryAppointmentsDataContext.cs.

Suggested change
"InMemoryAppointmentsDataContext"
"InMemoryAppointmentsDataContext.cs"

Copilot uses AI. Check for mistakes.
Comment on lines 5248 to +5265
"Title": "Async Upload",
"Name": "FileUploading",
"DocUrl": "Guide/UI_Components/FileUploader/Upload_Files/Client-Side_Settings/",
"Widget": "FileUploader",
"BackendFiles": [
"FileUploaderController.cs"
]
],
"DisableExternalEditor": true
},
{
"Title": "Validation",
"Name": "Validation",
"DocUrl": "",
"Widget": "FileUploader",
"BackendFiles": [
"FileUploaderController.cs"
]
],
"DisableExternalEditor": true
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the FileUploader section, DisableExternalEditor is added for “Async Upload” and “Validation”, but “Form Upload” (lines ~5234–5246) and “Chunk Upload” (lines ~5267–5278) still declare BackendFiles and do not set DisableExternalEditor. If backend-dependent demos should not be opened in external editors, these entries likely need the flag too for consistent behavior.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants