feature(demos): add vendor bundles for demos - #34760
Open
ajivanyandev wants to merge 7 commits into
Open
Conversation
vorobey
reviewed
Aug 17, 2026
| devextreme-vue-installer.tgz | ||
| retention-days: 1 | ||
|
|
||
| # UNTESTED DRAFT — diff-reviewed locally only, never run in real CI. |
Contributor
There was a problem hiding this comment.
this comment is still actual? seems like an leftover from claude/copilot
|
|
||
| import { Component } from '@angular/core'; | ||
|
|
||
| // TODO: restore the original demo (see git history for this file, app.component.html, |
Contributor
There was a problem hiding this comment.
I prupose to get make this TODO less verbose - am I right, this is a fix for demos that don't build properly because of feature-branch?
| @@ -0,0 +1,43 @@ | |||
| // CLI: node utils/server/build-vendor-bundles.js [React|Vue ...] | |||
Contributor
There was a problem hiding this comment.
i propose to declare smth like const DEFAULT_SAFE_BATCH_SIZE and use it here
| @@ -177,6 +177,7 @@ | |||
| "test-testcafe:accessibility": "cross-env STRATEGY=accessibility CONSTEL=jquery node utils/visual-tests/testcafe-runner.ts", | |||
| "csp-server": "node utils/server/csp-server.js 8080", | |||
| "csp-check": "node utils/server/csp-check.js", | |||
| "build-vendor-bundles": "node utils/server/build-vendor-bundles.js", | |||
Contributor
There was a problem hiding this comment.
what do you think to add building vendors in prepare-js or demos:prepare pipeline? i mean, without vendors, demos won't start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.