CI: Remove approve-package-publishing job from packages publishing - #34783
Merged
r-farkhutdinov merged 3 commits intoAug 17, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions package publishing workflow to remove the dedicated “approval” job and instead apply environment gating directly within the publishing stage.
Changes:
- Removed the
approve-package-publishingjob and thebuildjob dependency/condition that waited for it. - Added a conditional
environment:assignment to thepublishjob to select betweenpackages-publishingandpackages-publishing-automation.
Suppressed comments (1)
.github/workflows/packages_publishing.yml:169
- The
environmentexpression will evaluate to the booleantruewheninputs.tag == 'stable'(because||short-circuits before the&& 'packages-publishing'part). GitHub Actions expects an environment name (string), so this can break stable publishing runs.
needs: build
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
44
to
46
| build: | ||
| name: Build packages | ||
| runs-on: ubuntu-latest |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ruslan Farkhutdinov <23283554+r-farkhutdinov@users.noreply.github.com>
alexslavr
approved these changes
Aug 17, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.