Grids: remove m_ prefix from stateStoring core - #34788
Merged
anna-shakhova merged 1 commit intoAug 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames (and effectively de-prefixes) the grid core State Storing controller by introducing a new state_storing_controller_core module and updating internal imports (including PivotGrid) to reference it instead of the old m_-prefixed path.
Changes:
- Added
state_storing_controller_core.tswith the coreStateStoringControllerimplementation. - Updated PivotGrid and grid core modules/types to import
StateStoringControllerfrom the new core file. - Updated PivotGrid tests to stub the controller from the new module path.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/dataController.tests.js | Updates test import to the new state storing core controller module. |
| packages/devextreme/js/__internal/grids/pivot_grid/data_controller/m_data_controller.ts | Switches PivotGrid data controller dependency to the new state storing core controller module. |
| packages/devextreme/js/__internal/grids/grid_core/state_storing/state_storing_controller.ts | Repoints GridStateStoringController to extend the controller from the new core module. |
| packages/devextreme/js/__internal/grids/grid_core/state_storing/state_storing_controller_core.ts | Introduces the new core StateStoringController implementation (new file). |
| packages/devextreme/js/__internal/grids/grid_core/state_storing/extenders/state_storing_data_controller.ts | Updates type import to the new core controller module. |
| packages/devextreme/js/__internal/grids/grid_core/selection/m_selection.ts | Updates StateStoringController type import path to the new core module. |
| packages/devextreme/js/__internal/grids/grid_core/m_types.ts | Updates controller type mapping to reference the new core module path. |
| packages/devextreme/js/__internal/grids/grid_core/columns_controller/m_columns_controller.ts | Updates StateStoringController type import path to the new core module. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Tucchhaa
previously approved these changes
Aug 17, 2026
anna-shakhova
force-pushed
the
rename_state_storing_main
branch
from
August 17, 2026 08:45
bed48fb to
bc9788d
Compare
sjbur
approved these changes
Aug 17, 2026
Tucchhaa
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.