feat(dgw): cap the size of a session recording log push - #2002
Closed
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 3 commits into
Closed
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 3 commits into
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 3 commits into
Conversation
A log push (`.slog`) is now closed once it reaches 64 MiB. The Gateway closes it with WebSocket close code 4011. The media push next to it keeps running. Media pushes have no size limit. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
irvingouj@Devolutions (irvingoujAtDevolution)
deleted the
feat/jrec-slog-size-limit
branch
September 25, 2026 20:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2001.
Caps a
.slogpush at 64 MiB. Hitting the cap closes only the log push with close code 4011 (next to 4010 for storage full), and the media push keeps going. Media pushes have no cap.Tests:
cargo test -p devolutions-gateway --lib(recording, jrec, token, streaming, session) 32/32, clippy clean.🤖 Generated with Claude Code