build(deps): upgrade reqwest to 0.13 - #2004
Draft
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 2 commits into
Draft
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 2 commits into
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 2 commits into
Conversation
Moves http-client-proxy, devolutions-gateway, devolutions-agent and the testsuite to reqwest 0.13, keeping TLS and proxy behavior unchanged. - TLS stays rustls with ring and no OpenSSL. reqwest 0.13 dropped rustls-tls-native-roots, so clients now use rustls-no-provider and http_client_proxy::with_native_roots, which trusts exactly the native root certificates, like before, instead of rustls-platform-verifier. - Proxy behavior is unchanged: system-proxy stays disabled and the Off/System/Manual handling in http-client-proxy is the same. Checked with cargo +nightly fmt, cargo clippy --workspace --tests -D warnings, and cargo test --workspace. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Let maintainers know that an action is required on their side
|
…ve provider install to main
Follow-up to the reqwest 0.13 upgrade.
- with_native_roots now returns an error when the native store has
certificates but none of them is valid. The message and source match
what reqwest 0.12 returned from ClientBuilder::build ("builder error:
zero valid certificates found in native root store"). An empty store
is still not an error.
- with_native_roots no longer installs the ring provider. The agent now
installs it at the top of main, like the gateway already does, and the
function docs state the precondition.
- build_client_with_proxy and get_or_create_cached_client return
anyhow::Result, and UpdaterError::FileDownload carries anyhow::Error.
- Added a FIXME about ironrdp-tokio 0.10 still pulling reqwest 0.12 into
the agent, and comments on why invalid certificates are filtered and
why the forwarding client panics like reqwest 0.12's Client::new.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the workspace to reqwest 0.13. Needed so the upcoming AI crate (rig) can use Gateway's own proxy-aware client.
Behaviour stays the same:
http_client_proxy::with_native_roots, ring as provider (installed in each binary'smain), no OpenSSL / aws-lcHTTP_PROXYetc.) are honoured like before; the agent also reads the Windows/macOS system proxy, same as before, because ironrdp-tokio 0.10 still enables reqwest 0.12'ssystem-proxyand hyper-util is sharedreqwest 0.12 is still pulled in by
ironrdp-tokio0.10 (agent only, FIXME in its Cargo.toml).Tested: workspace clippy clean,
http-client-proxy20/20, agent + gateway test suites green, agent tunnel enrollment test.First of a stack for AI-generated session logs.
🤖 Generated with Claude Code