Skip to content

feat: Reduce logging noise#1576

Open
dan-fernandes wants to merge 4 commits into
mainfrom
reduce-logging-noise
Open

feat: Reduce logging noise#1576
dan-fernandes wants to merge 4 commits into
mainfrom
reduce-logging-noise

Conversation

@dan-fernandes

Copy link
Copy Markdown
Contributor

Now only logs PUT and POST at info level, with all other request methods at debug.

For GET requests, does not log both before and after processing request.

@dan-fernandes dan-fernandes requested a review from a team as a code owner June 26, 2026 14:00
@dan-fernandes dan-fernandes changed the title Reduce logging noise feat: Reduce logging noise Jun 26, 2026
Comment thread src/blueapi/service/main.py Outdated
Logs POST and PUT as info, all else as debug."""
log = (
LOGGER.info
if request.method == "POST" or request.method == "PUT"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be simpler to special case GET instead of both POST and PUT? DELETE at info could potentially be useful

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - good point

@tpoliaw tpoliaw linked an issue Jun 26, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce logging of http requests

2 participants