Selective upstream file download#835
Merged
Merged
Conversation
…nfo' Pydantic model
… the search strings stored in the MachineConfig if no search strings were provided by the API endpoint functions that call it
…rings' is also passed along the chain
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
+ Coverage 53.10% 53.15% +0.04%
==========================================
Files 100 100
Lines 10855 10863 +8
Branches 1439 1441 +2
==========================================
+ Hits 5765 5774 +9
+ Misses 4783 4782 -1
Partials 307 307 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
….session_control'
…on to 'run_upstream_file_download_request' to make its purpose more self-evident
…quest_upstream_file_download'
tieneupin
added
enhancement
d-j-hatton
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of providing users with finer control over which upstream files to select and download, the API endpoints for the instrument server and backend server were updated to receive and pass along a list of search strings from the frontend. If no search strings are received, it will refer back to the
MachineConfigto extract and pass along the full list of search strings configured for the specified upstream instrument.This PR is tied to DiamondLightSource/murfey-frontend#77 . Both should be deployed in tandem.