fix(logs): don't classify explicit non-error key/values as error#4824
Open
Siumauricio wants to merge 2 commits into
Open
fix(logs): don't classify explicit non-error key/values as error#4824Siumauricio wants to merge 2 commits into
Siumauricio wants to merge 2 commits into
Conversation
Lines like 'failed: false, error: none' (e.g. ofelia job summaries for successful runs) were rendered red because the error patterns matched the key regardless of its value. Strip key/value pairs whose value explicitly reports a non-error before running the error keyword patterns. Fixes #4538
dosubot
Bot
added
size:S
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The log viewer's
getLogTypematched error keywords against the key of a key/value pair while ignoring its value, so successful lines like ofelia's job summary:rendered red as errors. Reproduced with a unit test against the current classifier.
Now key/value pairs whose value explicitly reports a non-error (
error: none|null|nil|false|0|-|"",failed: false|no|0,failures=0,:or=separators) are stripped before the error patterns run. Real failures (failed: true,error: exit code 1) still classify as errors, and statusCode-based classification is untouched.Related #4589 — keyword-based inference still applies when a line carries no explicit level; this PR removes the false positives where the line itself states success.
Fixes #4538