fix(wss): terminate disconnected container log streams#4836
Open
gilangh wants to merge 1 commit into
Open
Conversation
gilangh
marked this pull request as ready for review
July 16, 2026 13:06
AminDhouib
added a commit
to DevinoSolutions/dokploy-community
that referenced
this pull request
Jul 18, 2026
port: fix(wss): terminate disconnected container log streams (upstream Dokploy#4836)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Closes #4835.
The runtime Logs tab streams through
/docker-container-logs. Previously, local streams randocker logs --followbehind a shell/PTTY and disconnect cleanup only killed that wrapper; remote cleanup only ended the SSH client. Cleanup was also registered after asynchronous authentication/server lookup, leaving a race where a browser could disconnect before the log process was tracked.This change:
SIGTERMtoSIGKILLafter one second if needed;Checklist
Before submitting this PR, please make sure that:
canarybranch.Validation performed with Node.js 24.4.0:
pnpm exec vitest --config __test__/vitest.config.ts __test__/wss/utils.test.ts --run(22 tests passed)pnpm --filter=dokploy typecheckpnpm --filter=@dokploy/server typecheckpnpm --filter=dokploy build-serverIssues related (if applicable)
Closes #4835.
Screenshots (if applicable)
Not applicable; this changes server-side process lifecycle and disconnect handling.