fix(domains): don't render CDN info message as an error in DNS tooltip - #4911
Open
AbiRaditya wants to merge 1 commit into
Open
fix(domains): don't render CDN info message as an error in DNS tooltip#4911AbiRaditya wants to merge 1 commit into
AbiRaditya wants to merge 1 commit into
Conversation
validateDomain returns isValid: true for CDN-fronted domains but reuses the `error` field to carry the provider's informational warning. Both domain tooltips branched on `error` alone, so the message rendered under a red "Error:" heading even though the badge correctly showed a green "Behind Cloudflare" state. Check the valid+message case first, matching how the badge already distinguishes the two. Applied to both the table view (columns.tsx) and the card view (show-domains.tsx), which shares the same tooltip. Fixes Dokploy#4910 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
AbiRaditya
marked this pull request as ready for review
July 26, 2026 14:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
validateDomaintreats a CDN-fronted domain as valid, but reuses theerrorfield to carry the provider's informational warning:show-domains.tsxalready untangles this when storing state (message: result.error && result.isValid ? result.error : undefined), and the badge readsmessageto render the green "Behind Cloudflare" label correctly. The tooltip, however, branched onerroralone — so the informational text was displayed under a red Error: heading, as reported in #4910.This checks the valid +
messagecase first, mirroring the distinction the badge already makes.Note that the same tooltip is duplicated in two places, so both are fixed:
columns.tsx— the domains table viewshow-domains.tsx— the card view, which is the one in the issue screenshot ("Behind Cloudflare")Fixing only the table view would leave the reported repro unchanged.
Checklist
Before submitting this PR, please make sure that:
canarybranch.Repro for anyone verifying:
detectCDNProvidermatches the resolved IP against CDN ranges, so any Cloudflare-fronted domain (e.g.discord.com) added as an application domain will hit the CDN branch — you don't need to own a domain on Cloudflare.Issues related (if applicable)
closes #4910
Screenshots (if applicable)