Fixed or suppressed IDE0079 warnings as appropriate.

StyleCop.Analyzers/StyleCop.Analyzers.Test/Helpers/UseCultureAttribute.cs

@@ -27,9 +27,11 @@ public class UseCultureAttribute : BeforeAfterTestAttribute
     {
         private readonly Lazy<CultureInfo> culture;
 
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable SA1305 // Field names should not use Hungarian notation
         private readonly Lazy<CultureInfo> uiCulture;
 #pragma warning restore SA1305 // Field names should not use Hungarian notation
+#pragma warning restore IDE0079 // Remove unnecessary suppression
 
         private CultureInfo originalCulture;
 
@@ -55,6 +57,7 @@ public UseCultureAttribute(string culture)
         {
         }
 
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable SA1305 // Field names should not use Hungarian notation
         /// <summary>
         /// Initializes a new instance of the <see cref="UseCultureAttribute"/>
@@ -64,6 +67,7 @@ public UseCultureAttribute(string culture)
         /// <param name="uiCulture">The name of the UI culture.</param>
         public UseCultureAttribute(string culture, string uiCulture)
 #pragma warning restore SA1305 // Field names should not use Hungarian notation
+#pragma warning restore IDE0079 // Remove unnecessary suppression
         {
             this.culture = new Lazy<CultureInfo>(() => new CultureInfo(culture));
             this.uiCulture = new Lazy<CultureInfo>(() => new CultureInfo(uiCulture));

StyleCop.Analyzers/StyleCop.Analyzers.Test/LightJson/JsonObjectTests.cs

@@ -140,8 +140,10 @@ public void TestDebugView()
             }
         }
 
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable IDE0060 // Remove unused parameter
         private static Type StaticType<T>(T value) => typeof(T);
 #pragma warning restore IDE0060 // Remove unused parameter
+#pragma warning restore IDE0079 // Remove unnecessary suppression
     }
 }

StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1116UnitTests.cs

@@ -5,9 +5,11 @@
 
 // Several test methods in this file use the same member data, but in some cases the test does not use all of the
 // supported parameters. See https://github.com/xunit/xunit/issues/1556.
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable xUnit1026 // Theory methods should use all of their parameters
 
 namespace StyleCop.Analyzers.Test.ReadabilityRules
+#pragma warning restore IDE0079 // Remove unnecessary suppression
 {
     using System.Collections.Generic;
     using System.Threading;

StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1121UnitTests.cs

@@ -5,9 +5,11 @@
 
 // Several test methods in this file use the same member data, but in some cases the test does not use all of the
 // supported parameters. See https://github.com/xunit/xunit/issues/1556.
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable xUnit1026 // Theory methods should use all of their parameters
 
 namespace StyleCop.Analyzers.Test.ReadabilityRules
+#pragma warning restore IDE0079 // Remove unnecessary suppression
 {
     using System;
     using System.Collections.Generic;

StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1130UnitTests.cs

@@ -19,11 +19,15 @@ namespace StyleCop.Analyzers.Test.ReadabilityRules
 
     public class SA1130UnitTests
     {
+#pragma warning disable IDE0079 // Remove unnecessary suppression
         [SuppressMessage("MicrosoftCodeAnalysisDesign", "RS1032:Define diagnostic message correctly", Justification = "The message here matches the compiler.")]
+#pragma warning restore IDE0079 // Remove unnecessary suppression
         private static readonly DiagnosticDescriptor CS1065 =
                    new DiagnosticDescriptor(nameof(CS1065), "Title", "Default values are not valid in this context.", "Category", DiagnosticSeverity.Error, AnalyzerConstants.EnabledByDefault);
 
+#pragma warning disable IDE0079 // Remove unnecessary suppression
         [SuppressMessage("MicrosoftCodeAnalysisDesign", "RS1032:Define diagnostic message correctly", Justification = "The message here matches the compiler.")]
+#pragma warning restore IDE0079 // Remove unnecessary suppression
         private static readonly DiagnosticDescriptor CS7014 =
                    new DiagnosticDescriptor(nameof(CS7014), "Title", "Attributes are not valid in this context.", "Category", DiagnosticSeverity.Error, AnalyzerConstants.EnabledByDefault);
 

StyleCop.Analyzers/StyleCop.Analyzers/AnalyzerConstants.cs

@@ -9,44 +9,35 @@ namespace StyleCop.Analyzers
     internal static class AnalyzerConstants
     {
         /// <summary>
-        /// Gets a reference value which can be passed to
-        /// <see cref="DiagnosticDescriptor(string, string, string, string, DiagnosticSeverity, bool, string, string, string[])"/>
-        /// to indicate that the diagnostic is disabled by default because it is an alternative to a reference StyleCop
-        /// rule.
+        /// Gets a value indicating whether the diagnostic is disabled by default because it is an alternative to a standard
+        /// StyleCop rule. It is used with
+        /// <see cref="DiagnosticDescriptor(string, string, string, string, DiagnosticSeverity, bool, string, string, string[])"/>.
         /// </summary>
         /// <value>
-        /// A reference value which can be passed to
-        /// <see cref="DiagnosticDescriptor(string, string, string, string, DiagnosticSeverity, bool, string, string, string[])"/>
-        /// to indicate that the diagnostic is disabled by default because it is an alternative to a reference StyleCop
-        /// rule.
+        /// A value indicating the diagnostic is disabled by default because it is an alternative to a standard  StyleCop rule.
+        /// It is used with
+        /// <see cref="DiagnosticDescriptor(string, string, string, string, DiagnosticSeverity, bool, string, string, string[])"/>.
         /// </value>
-        [SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1623:Property summary documentation should match accessors.", Justification = "This property behaves more like an opaque value than a Boolean.")]
         internal static bool DisabledAlternative => false;
 
         /// <summary>
-        /// Gets a reference value which can be passed to
-        /// <see cref="DiagnosticDescriptor(string, string, string, string, DiagnosticSeverity, bool, string, string, string[])"/>
-        /// to indicate that the diagnostic should be enabled by default.
+        /// Gets a value indicating whether the diagnostic should be enabled by default. It is used with
+        /// <see cref="DiagnosticDescriptor(string, string, string, string, DiagnosticSeverity, bool, string, string, string[])"/>.
         /// </summary>
         /// <value>
-        /// A reference value which can be passed to
-        /// <see cref="DiagnosticDescriptor(string, string, string, string, DiagnosticSeverity, bool, string, string, string[])"/>
-        /// to indicate that the diagnostic should be enabled by default.
+        /// A value indicating whether the diagnostic should be enabled by default. It is used with
+        /// <see cref="DiagnosticDescriptor(string, string, string, string, DiagnosticSeverity, bool, string, string, string[])"/>.
         /// </value>
-        [SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1623:Property summary documentation should match accessors.", Justification = "This property behaves more like an opaque value than a Boolean.")]
         internal static bool EnabledByDefault => true;
 
         /// <summary>
-        /// Gets a reference value which can be passed to
-        /// <see cref="DiagnosticDescriptor(string, string, string, string, DiagnosticSeverity, bool, string, string, string[])"/>
-        /// to indicate that the diagnostic should be disabled by default.
+        /// Gets a value indicating whether the diagnostic should be disabled by default. It is used with
+        /// <see cref="DiagnosticDescriptor(string, string, string, string, DiagnosticSeverity, bool, string, string, string[])"/>.
         /// </summary>
         /// <value>
-        /// A reference value which can be passed to
-        /// <see cref="DiagnosticDescriptor(string, string, string, string, DiagnosticSeverity, bool, string, string, string[])"/>
-        /// to indicate that the diagnostic should be disabled by default.
+        /// A value indicating whether the diagnostic should be disabled by default. It is used with
+        /// <see cref="DiagnosticDescriptor(string, string, string, string, DiagnosticSeverity, bool, string, string, string[])"/>.
         /// </value>
-        [SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1623:Property summary documentation should match accessors.", Justification = "This property behaves more like an opaque value than a Boolean.")]
         internal static bool DisabledByDefault => false;
     }
 }

StyleCop.Analyzers/StyleCop.Analyzers/AnalyzerExtensions.cs

@@ -25,7 +25,6 @@ internal static class AnalyzerExtensions
         /// </summary>
         /// <param name="context">The analysis context.</param>
         /// <param name="action">Action to be executed at completion of parsing of a document.</param>
-        [SuppressMessage("MicrosoftCodeAnalysisPerformance", "RS1012:Start action has no registered actions", Justification = "This is not a start action")]
         public static void RegisterSyntaxTreeAction(this CompilationStartAnalysisContext context, Action<SyntaxTreeAnalysisContext, StyleCopSettings> action)
         {
             var settingsFile = context.GetStyleCopSettingsFile(context.CancellationToken);
@@ -69,7 +68,6 @@ public static void RegisterSyntaxNodeAction<TLanguageKindEnum>(this CompilationS
         /// <param name="syntaxKinds">The kinds of syntax that should be analyzed.</param>
         /// <typeparam name="TLanguageKindEnum">Enum type giving the syntax node kinds of the source language for which
         /// the action applies.</typeparam>
-        [SuppressMessage("MicrosoftCodeAnalysisPerformance", "RS1012:Start action has no registered actions", Justification = "This is not a start action")]
         public static void RegisterSyntaxNodeAction<TLanguageKindEnum>(this CompilationStartAnalysisContext context, Action<SyntaxNodeAnalysisContext, StyleCopSettings> action, ImmutableArray<TLanguageKindEnum> syntaxKinds)
             where TLanguageKindEnum : struct
         {

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1603DocumentationMustContainValidXml.cs

@@ -33,20 +33,24 @@ internal class SA1603DocumentationMustContainValidXml : DiagnosticAnalyzer
         private static readonly LocalizableString Description = new LocalizableResourceString(nameof(DocumentationResources.SA1603Description), DocumentationResources.ResourceManager, typeof(DocumentationResources));
 
         private static readonly DiagnosticDescriptor Descriptor =
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable RS2000 // Add analyzer diagnostic IDs to analyzer release.
             new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, AnalyzerCategory.DocumentationRules, DiagnosticSeverity.Warning, AnalyzerConstants.DisabledByDefault, Description, HelpLink, WellKnownDiagnosticTags.NotConfigurable);
 #pragma warning restore RS2000 // Add analyzer diagnostic IDs to analyzer release.
+#pragma warning restore IDE0079 // Remove unnecessary suppression
 
         /// <inheritdoc/>
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } =
             ImmutableArray.Create(Descriptor);
 
         /// <inheritdoc/>
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable RS1025 // Configure generated code analysis
 #pragma warning disable RS1026 // Enable concurrent execution
         public override void Initialize(AnalysisContext context)
 #pragma warning restore RS1026 // Enable concurrent execution
 #pragma warning restore RS1025 // Configure generated code analysis
+#pragma warning restore IDE0079 // Remove unnecessary suppression
         {
             // This diagnostic is not implemented (by design) in StyleCopAnalyzers.
         }

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1612ElementParameterDocumentationMustMatchElementParameters.cs

@@ -112,6 +112,7 @@ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, Styl
 
                     if (parentParameters.Length <= index || parentParameters[index] != parentParameter)
                     {
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                         context.ReportDiagnostic(
                             Diagnostic.Create(
@@ -120,6 +121,7 @@ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, Styl
                                 nameAttributeText,
                                 parentParameters.IndexOf(parentParameter) + 1));
 #pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
+#pragma warning restore IDE0079 // Remove unnecessary suppression
                     }
                 }
 
@@ -185,6 +187,7 @@ protected override void HandleCompleteDocumentation(SyntaxNodeAnalysisContext co
 
                     if (parentParameters.Length <= index || parentParameters[index] != parentParameter)
                     {
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                         context.ReportDiagnostic(
                             Diagnostic.Create(
@@ -193,6 +196,7 @@ protected override void HandleCompleteDocumentation(SyntaxNodeAnalysisContext co
                                 nameAttributeText,
                                 parentParameters.IndexOf(parentParameter) + 1));
 #pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
+#pragma warning restore IDE0079 // Remove unnecessary suppression
                     }
                 }
 

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1628DocumentationTextMustBeginWithACapitalLetter.cs

@@ -49,20 +49,24 @@ internal class SA1628DocumentationTextMustBeginWithACapitalLetter : DiagnosticAn
         private static readonly LocalizableString Description = new LocalizableResourceString(nameof(DocumentationResources.SA1628Description), DocumentationResources.ResourceManager, typeof(DocumentationResources));
 
         private static readonly DiagnosticDescriptor Descriptor =
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable RS2000 // Add analyzer diagnostic IDs to analyzer release.
             new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, AnalyzerCategory.DocumentationRules, DiagnosticSeverity.Warning, AnalyzerConstants.DisabledByDefault, Description, HelpLink, WellKnownDiagnosticTags.NotConfigurable);
 #pragma warning restore RS2000 // Add analyzer diagnostic IDs to analyzer release.
+#pragma warning restore IDE0079 // Remove unnecessary suppression
 
         /// <inheritdoc/>
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } =
             ImmutableArray.Create(Descriptor);
 
         /// <inheritdoc/>
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable RS1025 // Configure generated code analysis
 #pragma warning disable RS1026 // Enable concurrent execution
         public override void Initialize(AnalysisContext context)
 #pragma warning restore RS1026 // Enable concurrent execution
 #pragma warning restore RS1025 // Configure generated code analysis
+#pragma warning restore IDE0079 // Remove unnecessary suppression
         {
             // This diagnostic is not implemented (by design) in StyleCopAnalyzers.
         }

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1630DocumentationTextMustContainWhitespace.cs

@@ -49,20 +49,24 @@ internal class SA1630DocumentationTextMustContainWhitespace : DiagnosticAnalyzer
         private static readonly LocalizableString Description = new LocalizableResourceString(nameof(DocumentationResources.SA1630Description), DocumentationResources.ResourceManager, typeof(DocumentationResources));
 
         private static readonly DiagnosticDescriptor Descriptor =
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable RS2000 // Add analyzer diagnostic IDs to analyzer release.
             new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, AnalyzerCategory.DocumentationRules, DiagnosticSeverity.Warning, AnalyzerConstants.DisabledByDefault, Description, HelpLink, WellKnownDiagnosticTags.NotConfigurable);
 #pragma warning restore RS2000 // Add analyzer diagnostic IDs to analyzer release.
+#pragma warning restore IDE0079 // Remove unnecessary suppression
 
         /// <inheritdoc/>
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } =
             ImmutableArray.Create(Descriptor);
 
         /// <inheritdoc/>
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable RS1025 // Configure generated code analysis
 #pragma warning disable RS1026 // Enable concurrent execution
         public override void Initialize(AnalysisContext context)
 #pragma warning restore RS1026 // Enable concurrent execution
 #pragma warning restore RS1025 // Configure generated code analysis
+#pragma warning restore IDE0079 // Remove unnecessary suppression
         {
             // This diagnostic is not implemented (by design) in StyleCopAnalyzers.
         }

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1631DocumentationMustMeetCharacterPercentage.cs

@@ -50,20 +50,24 @@ internal class SA1631DocumentationMustMeetCharacterPercentage : DiagnosticAnalyz
         private static readonly LocalizableString Description = new LocalizableResourceString(nameof(DocumentationResources.SA1631Description), DocumentationResources.ResourceManager, typeof(DocumentationResources));
 
         private static readonly DiagnosticDescriptor Descriptor =
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable RS2000 // Add analyzer diagnostic IDs to analyzer release.
             new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, AnalyzerCategory.DocumentationRules, DiagnosticSeverity.Warning, AnalyzerConstants.DisabledByDefault, Description, HelpLink, WellKnownDiagnosticTags.NotConfigurable);
 #pragma warning restore RS2000 // Add analyzer diagnostic IDs to analyzer release.
+#pragma warning restore IDE0079 // Remove unnecessary suppression
 
         /// <inheritdoc/>
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } =
             ImmutableArray.Create(Descriptor);
 
         /// <inheritdoc/>
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable RS1025 // Configure generated code analysis
 #pragma warning disable RS1026 // Enable concurrent execution
         public override void Initialize(AnalysisContext context)
 #pragma warning restore RS1026 // Enable concurrent execution
 #pragma warning restore RS1025 // Configure generated code analysis
+#pragma warning restore IDE0079 // Remove unnecessary suppression
         {
             // This diagnostic is not implemented (by design) in StyleCopAnalyzers.
         }