Skip to content

setRememberToken without password returns an empty string instead of the token #928

Open

Description

@VolodymyrLinuxovich

DefaultHTTPUtilities.setRememberToken(HttpServletRequest, HttpServletResponse, int, String, String) always returns an empty string when it succeeds.

The method builds the sealed token and adds the cookie. But it returns rval, which is set to "" at the top and never updated. The deprecated overload that takes a password returns cryptToken as expected. So callers of the newer method can't get the token they just set.

I mentioned this in #926 while fixing the HTTPUtilities Javadoc. Happy to send a small fix with a test.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions