Conversation
|
Did you try this locally with a fresh conda environment? I don't trust the CI tests on this one. As far as I can tell, the actual deployment of the website does not use a conda environment, so we need to test that this actually works within an environment. |
no, I was hoping you would, since you already have the conda env that exposed the problem in the first place. Lemme know if you strapped for time, I can test it meself 🍺 |
|
alas, ideally, we should include a GHA that run exactly that, so we catch an issue early on - if you give me the command sequence, I can pop a workflow in here |
|
I did what is described here: https://github.com/ESMValGroup/ESMValTool_Tutorial/blob/main/CONTRIBUTING.md#previewing-your-changes-locally cd ESMValTool_Tutorial
mamba env create -f environment.yml -n tut
mamba activate tut
make serveWith your changes, I get this now: $ make serve
bundle install && bundle update && bundle exec jekyll serve
Bundle complete! 1 Gemfile dependency, 93 gems now installed.
Bundled gems are installed into `./.vendor/bundle`
[DEPRECATED] Pass --all to `bundle update` to update everything
Fetching gem metadata from https://rubygems.org/...........
Resolving dependencies...
Bundle updated!
/home/manuel/ESMValTool_Tutorial/.vendor/bundle/ruby/4.0.0/gems/jekyll-3.9.0/lib/jekyll.rb:28: warning: csv used to be loaded from the standard library, but is not part of the default gems since Ruby 3.4.0.
You can add csv to your Gemfile or gemspec to fix this error.
bundler: failed to load command: jekyll (/home/manuel/ESMValTool_Tutorial/.vendor/bundle/ruby/4.0.0/bin/jekyll)
/home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/bundled_gems.rb:60:in 'Kernel.require': cannot load such file -- csv (LoadError)
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/bundled_gems.rb:60:in 'block (2 levels) in Kernel#replace_require'
from /home/manuel/ESMValTool_Tutorial/.vendor/bundle/ruby/4.0.0/gems/jekyll-3.9.0/lib/jekyll.rb:28:in '<top (required)>'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/bundled_gems.rb:60:in 'Kernel.require'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/bundled_gems.rb:60:in 'block (2 levels) in Kernel#replace_require'
from /home/manuel/ESMValTool_Tutorial/.vendor/bundle/ruby/4.0.0/gems/jekyll-3.9.0/exe/jekyll:8:in '<top (required)>'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/rubygems.rb:304:in 'Kernel#load'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/rubygems.rb:304:in 'Gem.activate_and_load_bin_path'
from /home/manuel/ESMValTool_Tutorial/.vendor/bundle/ruby/4.0.0/bin/jekyll:25:in '<top (required)>'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/bundler/cli/exec.rb:61:in 'Kernel.load'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/bundler/cli/exec.rb:61:in 'Bundler::CLI::Exec#kernel_load'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/bundler/cli/exec.rb:24:in 'Bundler::CLI::Exec#run'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/bundler/cli.rb:500:in 'Bundler::CLI#exec'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/bundler/vendor/thor/lib/thor/command.rb:28:in 'Bundler::Thor::Command#run'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/bundler/vendor/thor/lib/thor/invocation.rb:127:in 'Bundler::Thor::Invocation#invoke_command'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/bundler/vendor/thor/lib/thor.rb:538:in 'Bundler::Thor.dispatch'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/bundler/cli.rb:35:in 'Bundler::CLI.dispatch'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/bundler/vendor/thor/lib/thor/base.rb:584:in 'Bundler::Thor::Base::ClassMethods#start'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/bundler/cli.rb:29:in 'Bundler::CLI.start'
from /home/manuel/micromamba/envs/tut/lib/ruby/gems/4.0.0/gems/bundler-4.0.6/exe/bundle:28:in 'block in <top (required)>'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/bundler/friendly_errors.rb:118:in 'Bundler.with_friendly_errors'
from /home/manuel/micromamba/envs/tut/lib/ruby/gems/4.0.0/gems/bundler-4.0.6/exe/bundle:20:in '<top (required)>'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/rubygems.rb:304:in 'Kernel#load'
from /home/manuel/micromamba/envs/tut/lib/ruby/4.0.0/rubygems.rb:304:in 'Gem.activate_and_load_bin_path'
from /home/manuel/micromamba/envs/tut/bin/bundle:31:in '<main>'
make: *** [Makefile:49: serve] Error 1 |
|
OK thanks, Manu! I'll take it from here then - it's not as easy as I initially thought then |
Pull Request checklist
Attempt fix for #419 as reported by @schlunma
@LisaBock @rswamina @hb326 this also fixes the issue with the disallowed string format and I cranked up the max line length so the checker stops failing.
Before you start
Tasks
Lesson developmentsection in CONTRIBUTING.md and does not contain any spelling or grammatical errors.Lesson organizationandLesson formattingsections in CONTRIBUTING.md and does not contain any spelling or grammatical errors.make serve, alternativelymake docker-serve. Please see thePreviewing your changes locallysection in CONTRIBUTING.md for installation instructions.If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes {Link to the corresponding issue}