Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a singleFlight utility to coalesce concurrent cache misses for the same key into a single fetch operation, specifically for manifest loading in ReadSession. This optimization reduces redundant network requests during fan-out reads. Feedback suggests improving compatibility for environments without global DOMException and refining promise initialization to avoid type-casting hacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes bursts of duplicate manifest requests I was seeing in zarr-layer in some virtual datasets.