Relative path finding fix#23
Open
rmikalkenas wants to merge 1 commit intoEasyCorp:masterfrom
rmikalkenas:patch-1
Open
Relative path finding fix#23rmikalkenas wants to merge 1 commit intoEasyCorp:masterfrom rmikalkenas:patch-1
rmikalkenas wants to merge 1 commit intoEasyCorp:masterfrom
rmikalkenas:patch-1
Conversation
If `$this->localProjectDir = '/app'` and `$absolutePath = '/app/web/app_dev.php'` then `$relativePath = '/web_dev.php'` and `validatePathIsRelativeToProject` throws `InvalidConfigurationException`. As I understand it should remove absolute paths dir
fd6130
reviewed
Nov 12, 2021
| @@ -272,6 +272,10 @@ public function controllersToRemove(array $paths) : self | |||
|
|
|||
| $localRelativePaths = array_map(function ($absolutePath) { | |||
| $relativePath = str_replace($this->localProjectDir, '', $absolutePath); | |||
There was a problem hiding this comment.
Hi, i wonder why don't we just replace this line to $relativePath = mb_substr($absolutePath, mb_strlen($this->localProjectDir)); instead?
There was a problem hiding this comment.
Ok i get it now. Your solution indeed fix the issue you mentioned.
fd6130
approved these changes
Nov 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
$this->localProjectDir = '/app'and$absolutePath = '/app/web/app_dev.php'then$relativePath = '/web_dev.php'andvalidatePathIsRelativeToProjectthrowsInvalidConfigurationException.As I understand it should remove absolute paths dir