Bolt quote updates and improvements#9079
Open
nGoline wants to merge 10 commits intoElementsProject:masterfrom
Open
Bolt quote updates and improvements#9079nGoline wants to merge 10 commits intoElementsProject:masterfrom
nGoline wants to merge 10 commits intoElementsProject:masterfrom
Conversation
Collaborator
Author
|
Some changes overlap those in #9044, but some are new. |
Collaborator
Author
|
For clarity, I selected the BOLT commit a377265 as the |
nGoline
force-pushed
the
bolt-quote-update
branch
2 times, most recently
from
baccaa2 to
7fb9a7e
Compare
common/bolt11.c: Some BOLT quotes had changed slightly. run-bolt11.c: A test was updated to reflect nomenclature changes (from `signature recovery` to `public-key recovery`).
bolt12.c: - quote update on `bolt12_chains_match`; - add a new condition to `offer_decode` to check if the amount is greater than 0; run-bolt-12-encode-test.c: add check for `offer_amount > 0` run-bolt12-format-string-test.c: update BOLT quote bolt12-cli.c: update BOLT quote
update BOLT quotes that drifted from the current spec without changing the meaning or expected functionality.
…nstead of 12 blocks before forgetting a channel. test_gossip.py: Update the tests to reflect the changes.
The TLV `channel_type` is now mandatory. The code was correct but the quote was not.
new cases added by autogenerated mocks after updating the default BOLT spec version. bolt12.c: add new rules to satisfy case `offer_chains with zero entries`. bech32_util.c: fix padding on `from_bech32_charset` to satisfy case `Bech32 padding exceeds 4-bit limit`
…kheight + 72` blocks. Added 60 blocks to all tests that relied on this parameter in order to fix them. i.e. 12 -> 72, 13 -> 73, etc...
channeld.c: update logic to comply with BOLT quote. tests/test_splicing.py: update test to confirm we are not re-transmiting `channel_ready` for that specific case.
Extracted logic from if clause to variable for readability, and add extra checks to make sure a splice is active
channeld/channeld.c: Some BOLT quotes had changed slightly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgradeChangelog-None: changes made to BOLT quotes and tests